From a0c91a9ffb1db127cf1f06e285b208a544ed4567 Mon Sep 17 00:00:00 2001 From: "kalman@chromium.org" Date: Sat, 3 May 2014 03:41:43 +0000 Subject: Drive extension functions from ExtensionFunction::Run. The SyncExtensionFunction and AsyncExtensionFunction derivates now expose RunSync and RunAsync respectively. New extension function implementations should just implement Run directly. BUG=365732 R=rockot@chromium.org TBR=dmazzoni@chromium.org Review URL: https://codereview.chromium.org/257333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268033 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/extensions/api/cookies/cookies_api.cc | 8 ++++---- chrome/browser/extensions/api/cookies/cookies_api.h | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'chrome/browser/extensions/api/cookies') diff --git a/chrome/browser/extensions/api/cookies/cookies_api.cc b/chrome/browser/extensions/api/cookies/cookies_api.cc index 2de26a1..ed95507 100644 --- a/chrome/browser/extensions/api/cookies/cookies_api.cc +++ b/chrome/browser/extensions/api/cookies/cookies_api.cc @@ -205,7 +205,7 @@ CookiesGetFunction::CookiesGetFunction() { CookiesGetFunction::~CookiesGetFunction() { } -bool CookiesGetFunction::RunImpl() { +bool CookiesGetFunction::RunAsync() { parsed_args_ = Get::Params::Create(*args_); EXTENSION_FUNCTION_VALIDATE(parsed_args_.get()); @@ -278,7 +278,7 @@ CookiesGetAllFunction::CookiesGetAllFunction() { CookiesGetAllFunction::~CookiesGetAllFunction() { } -bool CookiesGetAllFunction::RunImpl() { +bool CookiesGetAllFunction::RunAsync() { parsed_args_ = GetAll::Params::Create(*args_); EXTENSION_FUNCTION_VALIDATE(parsed_args_.get()); @@ -343,7 +343,7 @@ CookiesSetFunction::CookiesSetFunction() : success_(false) { CookiesSetFunction::~CookiesSetFunction() { } -bool CookiesSetFunction::RunImpl() { +bool CookiesSetFunction::RunAsync() { parsed_args_ = Set::Params::Create(*args_); EXTENSION_FUNCTION_VALIDATE(parsed_args_.get()); @@ -458,7 +458,7 @@ CookiesRemoveFunction::CookiesRemoveFunction() { CookiesRemoveFunction::~CookiesRemoveFunction() { } -bool CookiesRemoveFunction::RunImpl() { +bool CookiesRemoveFunction::RunAsync() { parsed_args_ = Remove::Params::Create(*args_); EXTENSION_FUNCTION_VALIDATE(parsed_args_.get()); diff --git a/chrome/browser/extensions/api/cookies/cookies_api.h b/chrome/browser/extensions/api/cookies/cookies_api.h index 1389ffc..a7a0876 100644 --- a/chrome/browser/extensions/api/cookies/cookies_api.h +++ b/chrome/browser/extensions/api/cookies/cookies_api.h @@ -71,7 +71,7 @@ class CookiesGetFunction : public ChromeAsyncExtensionFunction { virtual ~CookiesGetFunction(); // ExtensionFunction: - virtual bool RunImpl() OVERRIDE; + virtual bool RunAsync() OVERRIDE; private: void GetCookieOnIOThread(); @@ -94,7 +94,7 @@ class CookiesGetAllFunction : public ChromeAsyncExtensionFunction { virtual ~CookiesGetAllFunction(); // ExtensionFunction: - virtual bool RunImpl() OVERRIDE; + virtual bool RunAsync() OVERRIDE; private: void GetAllCookiesOnIOThread(); @@ -115,7 +115,7 @@ class CookiesSetFunction : public ChromeAsyncExtensionFunction { protected: virtual ~CookiesSetFunction(); - virtual bool RunImpl() OVERRIDE; + virtual bool RunAsync() OVERRIDE; private: void SetCookieOnIOThread(); @@ -140,7 +140,7 @@ class CookiesRemoveFunction : public ChromeAsyncExtensionFunction { virtual ~CookiesRemoveFunction(); // ExtensionFunction: - virtual bool RunImpl() OVERRIDE; + virtual bool RunAsync() OVERRIDE; private: void RemoveCookieOnIOThread(); -- cgit v1.1