From 5322973d577a1064bb32eb19bd01c6aa5e7c51a5 Mon Sep 17 00:00:00 2001 From: "kalman@chromium.org" Date: Fri, 21 Jun 2013 02:56:02 +0000 Subject: Go back to JSON serialization of extension messages. base::Value pickling was causing OOMs on the browser, and V8ValueConverter has bugs. This is effectively a revert of both r204067 and r204496, except the json library replaced by the new safe $JSON, and it's eagerly included via our small-footprint v8::Extension. BUG=247530,248019,249419 R=mpcomplete@chromium.org TBR=cdn@chromium.org Review URL: https://chromiumcodereview.appspot.com/17144003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207675 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/extensions/api/messaging/extension_message_port.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'chrome/browser/extensions/api/messaging/extension_message_port.h') diff --git a/chrome/browser/extensions/api/messaging/extension_message_port.h b/chrome/browser/extensions/api/messaging/extension_message_port.h index 7cc386a..ccf9b69 100644 --- a/chrome/browser/extensions/api/messaging/extension_message_port.h +++ b/chrome/browser/extensions/api/messaging/extension_message_port.h @@ -9,10 +9,6 @@ class GURL; -namespace base { -class ListValue; -} - namespace content { class RenderProcessHost; } // namespace content @@ -34,7 +30,7 @@ class ExtensionMessagePort : public MessageService::MessagePort { const GURL& source_url) OVERRIDE; virtual void DispatchOnDisconnect(int source_port_id, const std::string& error_message) OVERRIDE; - virtual void DispatchOnMessage(scoped_ptr message, + virtual void DispatchOnMessage(const std::string& message, int target_port_id) OVERRIDE; virtual void IncrementLazyKeepaliveCount() OVERRIDE; virtual void DecrementLazyKeepaliveCount() OVERRIDE; -- cgit v1.1