From be341c7eacdfccf1720a3e7d96ff96a38a4fb187 Mon Sep 17 00:00:00 2001 From: "tc@google.com" Date: Mon, 13 Jul 2009 21:54:33 +0000 Subject: Revert "Always persist bookmark IDs." This reverts commit r20532 because valgrind was complaining about uninitialized memory: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/697/steps/valgrind%20test:%20unit/logs/stdio TBR=munjal Review URL: http://codereview.chromium.org/155448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20550 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/extensions/extension_bookmarks_module.h | 6 ------ 1 file changed, 6 deletions(-) (limited to 'chrome/browser/extensions/extension_bookmarks_module.h') diff --git a/chrome/browser/extensions/extension_bookmarks_module.h b/chrome/browser/extensions/extension_bookmarks_module.h index 7cfc1ca2..cfa32de 100644 --- a/chrome/browser/extensions/extension_bookmarks_module.h +++ b/chrome/browser/extensions/extension_bookmarks_module.h @@ -70,12 +70,6 @@ class BookmarksFunction : public AsyncExtensionFunction, virtual void Run(); virtual bool RunImpl() = 0; - protected: - // Helper to get the bookmark id as int64 from the given string id. - // Sets error_ to an errro string if the given id string can't be parsed - // as an int64. In case of error, doesn't change id and returns false. - bool GetBookmarkIdAsInt64(const std::string& id_string, int64* id); - private: virtual void Observe(NotificationType type, const NotificationSource& source, -- cgit v1.1