From 1790275fe70ec6f824a34632f2101b5256e5d218 Mon Sep 17 00:00:00 2001 From: "mihaip@chromium.org" Date: Wed, 31 Aug 2011 22:52:54 +0000 Subject: Remove obsolete TODO and add a bunch of OVERRIDEs. R=aa@chromium.org Review URL: http://codereview.chromium.org/7806009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99070 0039d316-1c4b-4281-b951-d872f2087c98 --- .../extensions/extension_browser_event_router.h | 32 ++++++++++++---------- 1 file changed, 17 insertions(+), 15 deletions(-) (limited to 'chrome/browser/extensions/extension_browser_event_router.h') diff --git a/chrome/browser/extensions/extension_browser_event_router.h b/chrome/browser/extensions/extension_browser_event_router.h index ddd878b..08e37a4 100644 --- a/chrome/browser/extensions/extension_browser_event_router.h +++ b/chrome/browser/extensions/extension_browser_event_router.h @@ -10,6 +10,7 @@ #include #include "base/basictypes.h" +#include "base/compiler_specific.h" #include "chrome/browser/extensions/extension_tabs_module.h" #include "chrome/browser/tabs/tab_strip_model_observer.h" #include "chrome/browser/ui/browser_list.h" @@ -42,15 +43,15 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver, void Init(); // BrowserList::Observer - virtual void OnBrowserAdded(const Browser* browser); - virtual void OnBrowserRemoved(const Browser* browser); - virtual void OnBrowserSetLastActive(const Browser* browser); + virtual void OnBrowserAdded(const Browser* browser) OVERRIDE; + virtual void OnBrowserRemoved(const Browser* browser) OVERRIDE; + virtual void OnBrowserSetLastActive(const Browser* browser) OVERRIDE; #if defined(TOOLKIT_VIEWS) virtual void NativeFocusWillChange(gfx::NativeView focused_before, - gfx::NativeView focused_now); + gfx::NativeView focused_now) OVERRIDE; #elif defined(TOOLKIT_GTK) - virtual void ActiveWindowChanged(GdkWindow* active_window); + virtual void ActiveWindowChanged(GdkWindow* active_window) OVERRIDE; #endif // Called from Observe() on BROWSER_WINDOW_READY (not a part of @@ -59,25 +60,26 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver, // TabStripModelObserver virtual void TabInsertedAt(TabContentsWrapper* contents, int index, - bool active); + bool active) OVERRIDE; virtual void TabClosingAt(TabStripModel* tab_strip_model, TabContentsWrapper* contents, - int index); - virtual void TabDetachedAt(TabContentsWrapper* contents, int index); + int index) OVERRIDE; + virtual void TabDetachedAt(TabContentsWrapper* contents, int index) OVERRIDE; virtual void ActiveTabChanged(TabContentsWrapper* old_contents, TabContentsWrapper* new_contents, int index, - bool user_gesture); + bool user_gesture) OVERRIDE; virtual void TabMoved(TabContentsWrapper* contents, int from_index, - int to_index); + int to_index) OVERRIDE; virtual void TabChangedAt(TabContentsWrapper* contents, int index, - TabChangeType change_type); + TabChangeType change_type) OVERRIDE; virtual void TabReplacedAt(TabStripModel* tab_strip_model, TabContentsWrapper* old_contents, TabContentsWrapper* new_contents, - int index); - virtual void TabPinnedStateChanged(TabContentsWrapper* contents, int index); - virtual void TabStripEmpty(); + int index) OVERRIDE; + virtual void TabPinnedStateChanged(TabContentsWrapper* contents, + int index) OVERRIDE; + virtual void TabStripEmpty() OVERRIDE; // Page Action execute event. void PageActionExecuted(Profile* profile, @@ -94,7 +96,7 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver, // NotificationObserver. virtual void Observe(int type, const NotificationSource& source, - const NotificationDetails& details); + const NotificationDetails& details) OVERRIDE; private: // "Synthetic" event. Called from TabInsertedAt if new tab is detected. void TabCreatedAt(TabContents* contents, int index, bool active); -- cgit v1.1