From 66bd33dbf76732655a7d5b156b895e78274ea1bc Mon Sep 17 00:00:00 2001 From: "rafaelw@chromium.org" Date: Tue, 24 Nov 2009 00:19:54 +0000 Subject: Fix crash when an extension popup shows a JS alert. Showing the alert takes... Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show. Disable showing JS alerts from popups, because doing so makes the popup disappear immediately, which has all sorts of unfortunate side effects for the poor orphaned alert (see bug for details). BUG=27758 TEST=create extension with popup, put link with |onclick="alert('test');"| in it; install extension, open popup, and click link; see no crash (nor popup) Review URL: http://codereview.chromium.org/435010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32889 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/extensions/extension_host.h | 1 + 1 file changed, 1 insertion(+) (limited to 'chrome/browser/extensions/extension_host.h') diff --git a/chrome/browser/extensions/extension_host.h b/chrome/browser/extensions/extension_host.h index 9407b85..e3ae680 100644 --- a/chrome/browser/extensions/extension_host.h +++ b/chrome/browser/extensions/extension_host.h @@ -156,6 +156,7 @@ class ExtensionHost : public ExtensionPopupHost::PopupDelegate, const std::wstring& prompt); virtual void SetSuppressMessageBoxes(bool suppress_message_boxes) {} virtual TabContents* AsTabContents() { return NULL; } + virtual ExtensionHost* AsExtensionHost() { return this; } private: friend class ProcessCreationQueue; -- cgit v1.1