From fe0eca5c30281ae58cef01593f0e4aab7fd560f2 Mon Sep 17 00:00:00 2001 From: "asargent@chromium.org" Date: Wed, 16 Nov 2011 06:49:10 +0000 Subject: Fix for management API related to escalated permissions disabled extensions The general approach is to require user gesture and put up the confirmation UI if an extension wants to re-enable a disabled-due-to-permissions-escalation extension. Also added some new infrastructure for making this easier to test. BUG=102579 TEST=See bug Review URL: http://codereview.chromium.org/8423069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110264 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/extensions/extension_install_dialog.h | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'chrome/browser/extensions/extension_install_dialog.h') diff --git a/chrome/browser/extensions/extension_install_dialog.h b/chrome/browser/extensions/extension_install_dialog.h index 8f0ada4..4124635 100644 --- a/chrome/browser/extensions/extension_install_dialog.h +++ b/chrome/browser/extensions/extension_install_dialog.h @@ -20,13 +20,19 @@ namespace base { class DictionaryValue; } -// The implementations of this function are platform-specific. void ShowExtensionInstallDialog(Profile* profile, ExtensionInstallUI::Delegate* delegate, const Extension* extension, SkBitmap* icon, const ExtensionInstallUI::Prompt& prompt); +// The implementations of this function are platform-specific. +void ShowExtensionInstallDialogImpl(Profile* profile, + ExtensionInstallUI::Delegate* delegate, + const Extension* extension, + SkBitmap* icon, + const ExtensionInstallUI::Prompt& prompt); + // Wrapper around ShowExtensionInstallDialog that shows the install dialog for // a given manifest (that corresponds to an extension about to be installed with // ID |id|). If the name or description in the manifest is a localized @@ -49,9 +55,9 @@ bool ShowExtensionInstallDialogForManifest( scoped_refptr* dummy_extension); // For use only in tests - sets a flag that makes invocations of -// ShowExtensionInstallDialogForManifest skip putting up a real dialog, and +// ShowExtensionInstallDialog* skip putting up a real dialog, and // instead act as if the dialog choice was to proceed or abort. -void SetExtensionInstallDialogForManifestAutoConfirmForTests( +void SetExtensionInstallDialogAutoConfirmForTests( bool should_proceed); #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_DIALOG_H_ -- cgit v1.1