From d5471d936f1fa0be56453a92fd8917d9101ec0bd Mon Sep 17 00:00:00 2001 From: "finnur@chromium.org" Date: Fri, 6 Nov 2009 20:28:34 +0000 Subject: Extensions UI page should not allow Reload forextensions that are not 'in development' andshould not DCHECK when uninstalling a disabledextension.I also reordered the links on the page, now thatwe show the Reload link conditionally, sinceit is weird to enable extensions after this change.The order starts out as...Disable - Reload - Uninstall... then when you press Disable it becomes: Enable - Uninstallpress Enable, it becomes:Disable - Reload - UninstallNotice how the Reload link pops up where Enable linkwas and where you'd expect Disable to be?TEST=Open chrome://extensions and make sure extensionsloaded with --load-extension have the Reload optionand when you disable an extension it does not DCHECKin debug version of Chrome.BUG=http://crbug.com/26901, http://crbug.com/26910 Review URL: http://codereview.chromium.org/374014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31285 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/extensions/extensions_ui.cc | 2 ++ 1 file changed, 2 insertions(+) (limited to 'chrome/browser/extensions/extensions_ui.cc') diff --git a/chrome/browser/extensions/extensions_ui.cc b/chrome/browser/extensions/extensions_ui.cc index 7cc5118..55c05e0 100644 --- a/chrome/browser/extensions/extensions_ui.cc +++ b/chrome/browser/extensions/extensions_ui.cc @@ -597,6 +597,8 @@ DictionaryValue* ExtensionsDOMHandler::CreateExtensionDetailValue( extension_data->SetString(L"description", extension->description()); extension_data->SetString(L"version", extension->version()->GetString()); extension_data->SetBoolean(L"enabled", enabled); + extension_data->SetBoolean(L"allow_reload", + extension->location() == Extension::LOAD); // Determine the sort order: Extensions loaded through --load-extensions show // up at the top. Disabled extensions show up at the bottom. -- cgit v1.1