From 7577a5c5f3fbddaf9506e00904c21b2a4525e30b Mon Sep 17 00:00:00 2001 From: "aa@chromium.org" Date: Thu, 30 Jul 2009 06:21:58 +0000 Subject: Pull CrxInstaller out of ExtensionsService. CrxInstaller is a new stateful object that encapsulates a single installation from unpack through notification. It currently contains the UI bits, but I suspect in the next CL (where I will finally implement the install UI) these will come out and CrxInstaller will become SilentCrxInstaller, and only used for updates and external installs. Also in this change, I removed the concept of install callbacks that ExtensionUpdater was using. This was only used to delete the temp crx file as far as I can tell, and we can easily keep state about that in CrxInstaller. With this CL, ExtensionsServiceBackend is almost completely dead, with only a few zombie methods left like LoadAllExtensions(). These should all become little objects like CrxInstaller that hold a reference to ExtensionsService over their lifetime and then kill themselves. I'll get to that eventually. Review URL: http://codereview.chromium.org/160311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22043 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/extensions/external_pref_extension_provider.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'chrome/browser/extensions/external_pref_extension_provider.cc') diff --git a/chrome/browser/extensions/external_pref_extension_provider.cc b/chrome/browser/extensions/external_pref_extension_provider.cc index f2ea35a..7b371ed 100644 --- a/chrome/browser/extensions/external_pref_extension_provider.cc +++ b/chrome/browser/extensions/external_pref_extension_provider.cc @@ -75,8 +75,8 @@ void ExternalPrefExtensionProvider::VisitRegisteredExtension( scoped_ptr version; version.reset(Version::GetVersionFromString(external_version)); - visitor->OnExternalExtensionFound( - WideToASCII(extension_id), version.get(), path); + visitor->OnExternalExtensionFound(WideToASCII(extension_id), version.get(), + path, Extension::EXTERNAL_PREF); } } -- cgit v1.1