From 5d028b7b577d2efb96cd958ba4a7f1e5800fd9bb Mon Sep 17 00:00:00 2001 From: "finnur@chromium.org" Date: Wed, 9 Jun 2010 21:19:40 +0000 Subject: Infobars on GTK (first part). I got it to a point where we show HTML content from the extension within an infobar, but there are a few things missing. Missing pieces: - Infobar does not size based on the height of its content (between 36px and 72px). - Infobar content always has a fixed width, but needs to fill out into the available infobar area. - I've put in code to asynchronously fetch the image for the Infobar, but it needs to be shown and hooked up to the ExtensionAction context menu (same context menu we use for the browser action container icons). - The background for HTML content should have a gradient, but is just solid blue at the moment. BUG=39916 TEST=Infobars should show up on GTK. Review URL: http://codereview.chromium.org/2753005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49319 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/extensions/extension_infobar_delegate.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'chrome/browser/extensions') diff --git a/chrome/browser/extensions/extension_infobar_delegate.cc b/chrome/browser/extensions/extension_infobar_delegate.cc index 09cd233..7bbc79b 100644 --- a/chrome/browser/extensions/extension_infobar_delegate.cc +++ b/chrome/browser/extensions/extension_infobar_delegate.cc @@ -57,12 +57,12 @@ void ExtensionInfoBarDelegate::InfoBarClosed() { delete this; } -#if !defined(TOOLKIT_VIEWS) +#if defined(OS_MACOSX) InfoBar* ExtensionInfoBarDelegate::CreateInfoBar() { NOTIMPLEMENTED(); return NULL; } -#endif // !TOOLKIT_VIEWS +#endif // OS_MACOSX void ExtensionInfoBarDelegate::Observe(NotificationType type, const NotificationSource& source, -- cgit v1.1