From c5e5de90817010774159243e097620c25e7d1d5d Mon Sep 17 00:00:00 2001 From: "finnur@chromium.org" Date: Tue, 26 Jun 2012 13:43:18 +0000 Subject: Add a comment in the ImageLoadingTracker about the image decoding. BUG=133471 TEST=None Review URL: https://chromiumcodereview.appspot.com/10658015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144168 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/extensions/image_loading_tracker.cc | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'chrome/browser/extensions') diff --git a/chrome/browser/extensions/image_loading_tracker.cc b/chrome/browser/extensions/image_loading_tracker.cc index b8c30bb..ea84c34 100644 --- a/chrome/browser/extensions/image_loading_tracker.cc +++ b/chrome/browser/extensions/image_loading_tracker.cc @@ -104,6 +104,12 @@ class ImageLoadingTracker::ImageLoader reinterpret_cast(file_contents.data()); webkit_glue::ImageDecoder decoder; scoped_ptr decoded(new SkBitmap()); + // Note: This class only decodes images from extension resources. Chrome + // doesn't (for security reasons) directly load extension resources provided + // by the extension author, but instead decodes them in a separate + // locked-down utility process. Only if the decoding succeeds is the image + // saved from memory to disk and subsequently used in the Chrome UI. + // Chrome is therefore decoding images here that were generated by Chrome. *decoded = decoder.Decode(data, file_contents.length()); if (decoded->empty()) { ReportBack(NULL, resource, gfx::Size(), id); -- cgit v1.1