From 07fd407c339c5d0469da916f22c718dbbf2f6746 Mon Sep 17 00:00:00 2001 From: "mdm@chromium.org" Date: Tue, 28 Jul 2009 22:13:14 +0000 Subject: Linux: it's not actually a bug to have the selection become empty in the URL picker. BUG=none TEST=in a debug build, go to wrench->options->basics, select "open the following pages", click "add", select something from the list, and then deselect it by holding ctrl and clicking it again; chromium should not crash Review URL: http://codereview.chromium.org/159540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21902 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/gtk/options/url_picker_dialog_gtk.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'chrome/browser/gtk') diff --git a/chrome/browser/gtk/options/url_picker_dialog_gtk.cc b/chrome/browser/gtk/options/url_picker_dialog_gtk.cc index 7042853..d6bf0eb 100644 --- a/chrome/browser/gtk/options/url_picker_dialog_gtk.cc +++ b/chrome/browser/gtk/options/url_picker_dialog_gtk.cc @@ -308,7 +308,7 @@ void UrlPickerDialogGtk::OnHistorySelectionChanged( GtkTreeSelection *selection, UrlPickerDialogGtk* window) { GtkTreeIter iter; if (!gtk_tree_selection_get_selected(selection, NULL, &iter)) { - NOTREACHED(); + // The user has unselected the history element, nothing to do. return; } GtkTreePath* path = gtk_tree_model_get_path( -- cgit v1.1