From 1599077a645a03c31c09efe57befaefbe00c958a Mon Sep 17 00:00:00 2001 From: "thakis@chromium.org" Date: Fri, 1 Oct 2010 20:03:11 +0000 Subject: Clang: make DCHECK_EQ(string16, string16) work. The problem is that string16 is a typedef for a std::basic_string with a custom base::char_traits, hence ADL looks for operator<< only in std and base, not in the global namespace. Since adding stuff to the global namespace isn't permitted, move the operator to namespace base instead. Also give WebString an explicit operator<< because clang can't figure out that it can use WebString's |operator string16| to print WebStrings. string16 is just wstring on windows, and gtest has special code to make printing wstrings to non-wide ostreams work already, so nothing is required on windows. Fix a few other minor issues. Based on a patch by hans@chromium.org BUG=57294 TEST=still compiles with gcc, fewer build errors in tests with clang Review URL: http://codereview.chromium.org/3515003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61218 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/idbbindingutilities_browsertest.cc | 1 + 1 file changed, 1 insertion(+) (limited to 'chrome/browser/idbbindingutilities_browsertest.cc') diff --git a/chrome/browser/idbbindingutilities_browsertest.cc b/chrome/browser/idbbindingutilities_browsertest.cc index a408379..c32a9ae 100644 --- a/chrome/browser/idbbindingutilities_browsertest.cc +++ b/chrome/browser/idbbindingutilities_browsertest.cc @@ -14,6 +14,7 @@ #include "googleurl/src/gurl.h" #include "testing/gtest/include/gtest/gtest.h" #include "webkit/glue/idb_bindings.h" +#include "webkit/glue/web_io_operators.h" #include "third_party/WebKit/WebKit/chromium/public/WebSerializedScriptValue.h" using WebKit::WebSerializedScriptValue; -- cgit v1.1