From a74efa3f82f1ce5ed2d61cfc1ac22410355eb32f Mon Sep 17 00:00:00 2001 From: "mattm@chromium.org" Date: Thu, 8 Oct 2009 01:51:39 +0000 Subject: Coverity: remove unused writer_ member from importer classes. CID=6427 BUG=none TEST=none Review URL: http://codereview.chromium.org/267020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28368 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/importer/firefox2_importer.h | 1 - chrome/browser/importer/ie_importer.h | 3 --- chrome/browser/importer/safari_importer.h | 1 - chrome/browser/importer/safari_importer.mm | 2 +- chrome/browser/importer/toolbar_importer.cc | 3 +-- chrome/browser/importer/toolbar_importer.h | 3 --- 6 files changed, 2 insertions(+), 11 deletions(-) (limited to 'chrome/browser/importer') diff --git a/chrome/browser/importer/firefox2_importer.h b/chrome/browser/importer/firefox2_importer.h index d9aa263..d517ee3 100644 --- a/chrome/browser/importer/firefox2_importer.h +++ b/chrome/browser/importer/firefox2_importer.h @@ -113,7 +113,6 @@ class Firefox2Importer : public Importer { const GURL& favicon_data, std::vector* favicons); - ProfileWriter* writer_; std::wstring source_path_; std::wstring app_path_; // If true, we only parse the bookmarks.html file specified as source_path_. diff --git a/chrome/browser/importer/ie_importer.h b/chrome/browser/importer/ie_importer.h index a43b660..f40d439e 100644 --- a/chrome/browser/importer/ie_importer.h +++ b/chrome/browser/importer/ie_importer.h @@ -59,9 +59,6 @@ class IEImporter : public Importer { // Determines which version of IE is in use. int CurrentIEVersion() const; - // Hosts the writer used in this importer. - ProfileWriter* writer_; - // IE PStore subkey GUID: AutoComplete password & form data. static const GUID kPStoreAutocompleteGUID; diff --git a/chrome/browser/importer/safari_importer.h b/chrome/browser/importer/safari_importer.h index 827880f..25f63f8 100644 --- a/chrome/browser/importer/safari_importer.h +++ b/chrome/browser/importer/safari_importer.h @@ -89,7 +89,6 @@ class SafariImporter : public Importer { const FaviconMap& favicon_map, std::vector* favicons); - ProfileWriter* writer_; FilePath library_dir_; DISALLOW_COPY_AND_ASSIGN(SafariImporter); diff --git a/chrome/browser/importer/safari_importer.mm b/chrome/browser/importer/safari_importer.mm index bcf3432..54a6d2a 100644 --- a/chrome/browser/importer/safari_importer.mm +++ b/chrome/browser/importer/safari_importer.mm @@ -40,7 +40,7 @@ bool CanImportSafariURL(const GURL& url) { } // namespace SafariImporter::SafariImporter(const FilePath& library_dir) - : writer_(NULL), library_dir_(library_dir) { + : library_dir_(library_dir) { } SafariImporter::~SafariImporter() { diff --git a/chrome/browser/importer/toolbar_importer.cc b/chrome/browser/importer/toolbar_importer.cc index a215fd8..669abab 100644 --- a/chrome/browser/importer/toolbar_importer.cc +++ b/chrome/browser/importer/toolbar_importer.cc @@ -74,8 +74,7 @@ const char Toolbar5Importer::kT5FrontEndUrlTemplate[] = // The constructor should set the initial state to NOT_USED. Toolbar5Importer::Toolbar5Importer() - : writer_(NULL), - state_(NOT_USED), + : state_(NOT_USED), items_to_import_(NONE), token_fetcher_(NULL), data_fetcher_(NULL) { diff --git a/chrome/browser/importer/toolbar_importer.h b/chrome/browser/importer/toolbar_importer.h index 61cdfb0..e2cf511 100644 --- a/chrome/browser/importer/toolbar_importer.h +++ b/chrome/browser/importer/toolbar_importer.h @@ -148,9 +148,6 @@ class Toolbar5Importer : public URLFetcher::Delegate, public Importer { void AddBookmarksToChrome( const std::vector& bookmarks); - // The writer used in this importer is stored in writer_. - ProfileWriter* writer_; - // Internal state is stored in state_. InternalStateEnum state_; -- cgit v1.1