From 0d3dc8e2804b0adc4f572944db027929e2b5af5a Mon Sep 17 00:00:00 2001 From: "jam@chromium.org" Date: Tue, 3 Nov 2009 02:27:01 +0000 Subject: Fifth patch in getting rid of caching MessageLoop pointers. BUG=25354 Review URL: http://codereview.chromium.org/345037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/login_prompt.h | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'chrome/browser/login_prompt.h') diff --git a/chrome/browser/login_prompt.h b/chrome/browser/login_prompt.h index bcb63d8..da67c07 100644 --- a/chrome/browser/login_prompt.h +++ b/chrome/browser/login_prompt.h @@ -19,7 +19,6 @@ struct PasswordForm; class ConstrainedWindow; class GURL; -class MessageLoop; class PasswordManager; class TabContents; class URLRequest; @@ -38,7 +37,7 @@ class LoginHandler { public: // Builds the platform specific LoginHandler. Used from within // CreateLoginPrompt() which creates tasks. - static LoginHandler* Create(URLRequest* request, MessageLoop* ui_loop); + static LoginHandler* Create(URLRequest* request); // Initializes the underlying platform specific view. virtual void BuildViewForPasswordManager(PasswordManager* manager, @@ -84,15 +83,14 @@ class LoginNotificationDetails { // Prompts the user for their username and password. This is designed to // be called on the background (I/O) thread, in response to // URLRequest::Delegate::OnAuthRequired. The prompt will be created -// on the main UI thread via a call to ui_loop's InvokeLater, and will send the +// on the main UI thread via a call to UI loop's InvokeLater, and will send the // credentials back to the URLRequest on the calling thread. // A LoginHandler object (which lives on the calling thread) is returned, // which can be used to set or cancel authentication programmatically. The // caller must invoke OnRequestCancelled() on this LoginHandler before // destroying the URLRequest. LoginHandler* CreateLoginPrompt(net::AuthChallengeInfo* auth_info, - URLRequest* request, - MessageLoop* ui_loop); + URLRequest* request); // Helper to remove the ref from an URLRequest to the LoginHandler. // Should only be called from the IO thread, since it accesses an URLRequest. -- cgit v1.1