From e4bece42eb898c7ea69000404d7459f879435495 Mon Sep 17 00:00:00 2001 From: "jar@chromium.org" Date: Fri, 19 Feb 2010 04:42:16 +0000 Subject: Revert 39421 - Switch to putting appversion at top level of XML This change puts appversion at the same level as buildtime, and so it is avalable (now) for use in histogram versioning, as well as stability versioning (or user metrics versioning). r=huanr Review URL: http://codereview.chromium.org/646056 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/651012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39423 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/metrics/metrics_log.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'chrome/browser/metrics/metrics_log.cc') diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc index fff2f2a..4ce5273 100644 --- a/chrome/browser/metrics/metrics_log.cc +++ b/chrome/browser/metrics/metrics_log.cc @@ -64,7 +64,6 @@ MetricsLog::MetricsLog(const std::string& client_id, int session_id) StartElement("log"); WriteAttribute("clientid", client_id_); WriteInt64Attribute("buildtime", GetBuildTime()); - WriteAttribute("appversion", GetVersionString()); DCHECK_GE(result, 0); } @@ -510,6 +509,7 @@ void MetricsLog::WriteInstallElement() { OPEN_ELEMENT_FOR_SCOPE("install"); WriteAttribute("installdate", GetInstallDate()); WriteIntAttribute("buildid", 0); // We're using appversion instead. + WriteAttribute("appversion", GetVersionString()); } void MetricsLog::RecordEnvironment( -- cgit v1.1