From 6cf85906b0504908e3fd0fafa46be78903bfd6b9 Mon Sep 17 00:00:00 2001 From: "brettw@google.com" Date: Tue, 19 Aug 2008 17:38:12 +0000 Subject: Cleans up notifications for the NavigationController. There were several notifications before and some of them were very unclear and misused (STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases as well. I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more clear and covers (I think!) all the cases that the callers care about. I added a simple notification testing helper class, and used in the navigation controller unit tests to make sure we get the proper notifications. I had to change NotificationSource/Details to have a = and copy constructor so I can track them easily in my helper. I don't see why this would be bad. BUG=1325636,1321376,1325779 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1039 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/navigation_controller.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'chrome/browser/navigation_controller.h') diff --git a/chrome/browser/navigation_controller.h b/chrome/browser/navigation_controller.h index 136540e..4378b04 100644 --- a/chrome/browser/navigation_controller.h +++ b/chrome/browser/navigation_controller.h @@ -133,9 +133,6 @@ class NavigationController : public NavigationControllerBase { const std::wstring& GetLazyTitle() const; const SkBitmap& GetLazyFavIcon() const; - // Called when |entry| has been updated outside its NavigationController. - void EntryUpdated(NavigationEntry* entry); - void SetAlternateNavURLFetcher( AlternateNavURLFetcher* alternate_nav_url_fetcher); @@ -200,7 +197,7 @@ class NavigationController : public NavigationControllerBase { virtual int GetMaxPageID() const; virtual void NavigateToPendingEntry(bool reload); - virtual void NotifyNavigationStateChanged(); + virtual void NotifyNavigationEntryCommitted(); // Lets the history database know navigation entries have been removed. virtual void NotifyPrunedEntries(); -- cgit v1.1