From 6314e6f6d7ac203479afe79a46a3e592a2a8da69 Mon Sep 17 00:00:00 2001 From: "phajdan.jr@chromium.org" Date: Wed, 15 Jul 2009 16:07:14 +0000 Subject: Fix a bunch of minor Coverity issues. - pass more things by const reference - check return codes (minor severity) Review URL: http://codereview.chromium.org/149643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20731 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/net/url_fixer_upper.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'chrome/browser/net/url_fixer_upper.cc') diff --git a/chrome/browser/net/url_fixer_upper.cc b/chrome/browser/net/url_fixer_upper.cc index 4097b88..fa572c3 100644 --- a/chrome/browser/net/url_fixer_upper.cc +++ b/chrome/browser/net/url_fixer_upper.cc @@ -29,7 +29,7 @@ namespace { // UTF8 to UTF16. Instead of this after-the-fact adjustment, we should parse it // in the correct string format to begin with. url_parse::Component UTF8ComponentToWideComponent( - string text_utf8, + const string& text_utf8, const url_parse::Component& component_utf8) { if (component_utf8.len == -1) return url_parse::Component(); @@ -44,7 +44,8 @@ url_parse::Component UTF8ComponentToWideComponent( return component_w; } -void UTF8PartsToWideParts(string text_utf8, const url_parse::Parsed& parts_utf8, +void UTF8PartsToWideParts(const string& text_utf8, + const url_parse::Parsed& parts_utf8, url_parse::Parsed* parts) { if (IsStringASCII(text_utf8)) { *parts = parts_utf8; -- cgit v1.1