From 8b7135d6aa44d68307bfb7ff5e6441fcf1c5231b Mon Sep 17 00:00:00 2001 From: "johnnyg@chromium.org" Date: Wed, 11 Nov 2009 17:40:31 +0000 Subject: Unit tests for desktop notifications. * Allow non-windows BalloonCollections to create non-viewable balloons (so that non-viewing aspects are cross-platform testable) * Makes NotificationObjectProxy overridable by a mock object which logs instead of calls to JS * Move Layout code from private to protected in BalloonCollection to enable verification of position code. BUG=none TEST=these Review URL: http://codereview.chromium.org/371041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31670 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/notifications/balloon_collection_mac.mm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'chrome/browser/notifications/balloon_collection_mac.mm') diff --git a/chrome/browser/notifications/balloon_collection_mac.mm b/chrome/browser/notifications/balloon_collection_mac.mm index 6197b49..2bff15e 100644 --- a/chrome/browser/notifications/balloon_collection_mac.mm +++ b/chrome/browser/notifications/balloon_collection_mac.mm @@ -4,14 +4,12 @@ #include "chrome/browser/notifications/balloon_collection.h" -#include "base/gfx/size.h" #include "base/logging.h" Balloon* BalloonCollectionImpl::MakeBalloon(const Notification& notification, Profile* profile) { - // TODO(johnnyg): http://crbug.com/23066. Part of future Mac support. - NOTIMPLEMENTED(); - return NULL; + // TODO(johnnyg): http://crbug.com/23066. Hook up to views. + return new Balloon(notification, profile, this); } bool BalloonCollectionImpl::Layout::RefreshSystemMetrics() { -- cgit v1.1