From 46ebf0640d32b313618fe443a34e959059b2c3f9 Mon Sep 17 00:00:00 2001
From: "ziadh@chromium.org"
 <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sat, 24 Jul 2010 02:47:40 +0000
Subject: Add undeclared virtual destructors.

Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.

r=jar

Review URL: http://codereview.chromium.org/2856051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53570 0039d316-1c4b-4281-b951-d872f2087c98
---
 chrome/browser/parsers/metadata_parser.h         | 4 ++++
 chrome/browser/parsers/metadata_parser_factory.h | 1 +
 2 files changed, 5 insertions(+)

(limited to 'chrome/browser/parsers')

diff --git a/chrome/browser/parsers/metadata_parser.h b/chrome/browser/parsers/metadata_parser.h
index 65210fa..65c57d0 100644
--- a/chrome/browser/parsers/metadata_parser.h
+++ b/chrome/browser/parsers/metadata_parser.h
@@ -13,6 +13,8 @@
 class MetadataPropertyIterator {
  public:
   MetadataPropertyIterator() {}
+  virtual ~MetadataPropertyIterator() {}
+
 
   // Gets the next Property in the iterator.  Returns false if at the end
   // of the list.
@@ -29,6 +31,8 @@ class MetadataPropertyIterator {
 class MetadataParser {
  public:
   explicit MetadataParser(const FilePath& path) {}
+  virtual ~MetadataParser() {}
+
 
   static const char* kPropertyType;
   static const char* kPropertyFilesize;
diff --git a/chrome/browser/parsers/metadata_parser_factory.h b/chrome/browser/parsers/metadata_parser_factory.h
index 2636804..553a785 100644
--- a/chrome/browser/parsers/metadata_parser_factory.h
+++ b/chrome/browser/parsers/metadata_parser_factory.h
@@ -12,6 +12,7 @@
 class MetadataParserFactory {
  public:
   MetadataParserFactory() {}
+  virtual ~MetadataParserFactory() {}
 
   // Used to check to see if the parser can parse the given file. This
   // should not do any additional reading of the file.
-- 
cgit v1.1