From cecc93a46dd560fe4157af3d098092eb395324d3 Mon Sep 17 00:00:00 2001 From: "ben@chromium.org" Date: Tue, 5 Oct 2010 15:58:55 +0000 Subject: Replace Browser::AddTabWithURL(...) with: - Browser::AddSelectedTabWithURL(const GURL& url, PageTransition::Type transition) -> A good many callsites just wanted a way to open a tab somewhere and select it. - Browser::AddTabWithURL(AddTabWithURLParams* params) -> For the callsites with specialized needs, this new signature allows the parameter set to change as features are added without having to update a bunch of callers every time. BUG=none TEST=existing unit tests Review URL: http://codereview.chromium.org/3599006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61517 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/platform_util_chromeos.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'chrome/browser/platform_util_chromeos.cc') diff --git a/chrome/browser/platform_util_chromeos.cc b/chrome/browser/platform_util_chromeos.cc index 2d70ef3..229563b 100644 --- a/chrome/browser/platform_util_chromeos.cc +++ b/chrome/browser/platform_util_chromeos.cc @@ -79,9 +79,7 @@ void OpenItem(const FilePath& full_path) { return; } Browser* browser = BrowserList::GetLastActive(); - browser->AddTabWithURL( - GURL(path), GURL(), PageTransition::LINK, -1, - TabStripModel::ADD_SELECTED, NULL, std::string(), NULL); + browser->AddSelectedTabWithURL(GURL(path), PageTransition::LINK); return; } if (ext == ".avi" || @@ -112,9 +110,7 @@ void OpenItem(const FilePath& full_path) { static void OpenURL(const std::string& url) { Browser* browser = BrowserList::GetLastActive(); - browser->AddTabWithURL( - GURL(url), GURL(), PageTransition::LINK, -1, - TabStripModel::ADD_SELECTED, NULL, std::string(), NULL); + browser->AddSelectedTabWithURL(GURL(url), PageTransition::LINK); } void OpenExternal(const GURL& url) { -- cgit v1.1