From 13f383ff5fc8ff095501794d4ce758f0067ff9b5 Mon Sep 17 00:00:00 2001 From: "darin@chromium.org" Date: Mon, 28 Sep 2009 18:12:55 +0000 Subject: Assert that thread-safe reference counting is used with cross-thread NewRunnableMethod. This assertion caught such an error in VisitedLinkMaster! My approach, modify RunnableMethodTraits to assert that when ReleaseCallee happens on a different thread from RetainCallee that the type supports thread-safe reference counting. I do this by adding a static method to both RefCounted and RefCountedThreadSafe. This results in a little ugliness in cases where people implement AddRef and Release by hand (to make the no-ops). There may be a nicer way to deal with those few cases. R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/251012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/printing/print_job_worker.cc | 3 --- 1 file changed, 3 deletions(-) (limited to 'chrome/browser/printing/print_job_worker.cc') diff --git a/chrome/browser/printing/print_job_worker.cc b/chrome/browser/printing/print_job_worker.cc index caf5ad3..375c2407 100644 --- a/chrome/browser/printing/print_job_worker.cc +++ b/chrome/browser/printing/print_job_worker.cc @@ -275,9 +275,6 @@ void PrintJobWorker::OnFailure() { } // namespace printing -RunnableMethodTraits::RunnableMethodTraits() { -} - void RunnableMethodTraits::RetainCallee( printing::PrintJobWorker* obj) { DCHECK(!owner_.get()); -- cgit v1.1