From 13c30929c4c0daaf891554ddb52ebebb80a36afa Mon Sep 17 00:00:00 2001 From: "eroman@chromium.org" Date: Thu, 19 Nov 2009 03:43:19 +0000 Subject: Cleanup some callers now that the restriction that ChromeURLRequestContextGetter be released from the IO thread is gone. This was an anoyance for consumers of URLRequestContextGetter, as they would play tricks doing manual AddRef/Release. The actual removal of this policy happened in: r32129. BUG=None Test=Existing tests don't crash/leak. Review URL: http://codereview.chromium.org/332006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32488 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/profile.h | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'chrome/browser/profile.h') diff --git a/chrome/browser/profile.h b/chrome/browser/profile.h index 7497e6d..98e7aab 100644 --- a/chrome/browser/profile.h +++ b/chrome/browser/profile.h @@ -116,9 +116,6 @@ class Profile { // from any thread. This CAN return NULL if a first request context has not // yet been created. If necessary, listen on the UI thread for // NOTIFY_DEFAULT_REQUEST_CONTEXT_AVAILABLE. - // - // The returned object is ref'd by the profile. Callers who AddRef() it (to - // keep it alive longer than the profile) must Release() it on the I/O thread. static URLRequestContextGetter* GetDefaultRequestContext(); // Returns a unique Id that can be used to identify this profile at runtime. @@ -278,9 +275,6 @@ class Profile { // Returns the request context information associated with this profile. Call // this only on the UI thread, since it can send notifications that should // happen on the UI thread. - // - // The returned object is ref'd by the profile. Callers who AddRef() it (to - // keep it alive longer than the profile) must Release() it on the I/O thread. virtual URLRequestContextGetter* GetRequestContext() = 0; // Returns the request context for media resources asociated with this @@ -548,11 +542,11 @@ class ProfileImpl : public Profile, scoped_ptr sync_service_; - ChromeURLRequestContextGetter* request_context_; + scoped_refptr request_context_; - ChromeURLRequestContextGetter* media_request_context_; + scoped_refptr media_request_context_; - ChromeURLRequestContextGetter* extensions_request_context_; + scoped_refptr extensions_request_context_; scoped_ptr ssl_config_service_manager_; -- cgit v1.1