From 04b4a6c37ac2250bc4e7230c24801d5cf9ffd8e7 Mon Sep 17 00:00:00 2001 From: "ojan@google.com" Date: Sat, 2 Aug 2008 00:44:47 +0000 Subject: A bunch of cleanups to beforeunload/unload handling. 1. Remove all the is_closing_browser plumbing. WebContents/TabContents/RenderViewHost/etc really shouldn't (and don't!) need to know anything about whether we're closing the browser or not. 2. Refactor the handling of beforeunload/unload state in browser.cc. I think this makes it considerably easier to reason about the correctness of it. 3. Added a couple TODOs for future cleanups that would have made this change a bit too large. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/render_process_host.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'chrome/browser/render_process_host.cc') diff --git a/chrome/browser/render_process_host.cc b/chrome/browser/render_process_host.cc index feb1e32..c1f2b5f 100644 --- a/chrome/browser/render_process_host.cc +++ b/chrome/browser/render_process_host.cc @@ -531,11 +531,9 @@ void RenderProcessHost::UpdateMaxPageID(int32 page_id) { } void RenderProcessHost::CrossSiteClosePageACK(int new_render_process_host_id, - int new_request_id, - bool is_closing_browser) { + int new_request_id) { widget_helper_->CrossSiteClosePageACK(new_render_process_host_id, - new_request_id, - is_closing_browser); + new_request_id); } void RenderProcessHost::OnMessageReceived(const IPC::Message& msg) { -- cgit v1.1