From bf73f0bc6e83da6c7b4f9353be5b382ea91e6906 Mon Sep 17 00:00:00 2001 From: "phajdan.jr@chromium.org" Date: Wed, 10 Feb 2010 19:26:59 +0000 Subject: Make sure that ResourceQueue is shut down before destruction. Rewrite UserScriptListener unit test to not use ResourceDispatcherHost. Share more code with ExtensionsServiceTest. TEST=Covered by unit_tests. BUG=none Review URL: http://codereview.chromium.org/601005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38648 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/renderer_host/resource_queue.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'chrome/browser/renderer_host/resource_queue.cc') diff --git a/chrome/browser/renderer_host/resource_queue.cc b/chrome/browser/renderer_host/resource_queue.cc index 409f6b9..dca6bd2 100644 --- a/chrome/browser/renderer_host/resource_queue.cc +++ b/chrome/browser/renderer_host/resource_queue.cc @@ -17,8 +17,7 @@ ResourceQueue::ResourceQueue() : shutdown_(false) { } ResourceQueue::~ResourceQueue() { - // TODO(phajdan.jr): Add DCHECK(shutdown_) here when unit tests stop abusing - // ResourceDispatcherHost by not shutting it down in tests. + DCHECK(shutdown_); } void ResourceQueue::Initialize(const DelegateSet& delegates) { -- cgit v1.1