From f353dba90985f6f9314c932c6c0ad016e2701f75 Mon Sep 17 00:00:00 2001 From: "erg@chromium.org" Date: Fri, 24 May 2013 22:12:35 +0000 Subject: Revert 202038 "Remove all but one use of WeakPtrFactory::DetachF..." Caused local failures in linux_aura builds. Unsure why this isn't showing up on the bots. > Remove all but one use of WeakPtrFactory::DetachFromThread. > > This CL changes WeakPtr in the following ways: > * Changes thread-bindings semantics so that WeakPtrs only become bound when the first one is dereferenced, or the owning factory invalidates them. > * Removes WeakPtrFactory::DetachFromThread. > * Renames SupportsWeakPtr::DetachFromThread to DetachFromThreadHack. > > Calling code changes to allow this: > * Unnecessary DetachFromThread() calls removed from PluginInfoMessageFilter, DhcpProxyScript[Adapter]FetcherWin and (Chromoting's) PolicyWatcherLinux. > * DetachFromThread() calls rendered unnecessary by change in binding semantics removed from IOThread, SearchProviderInstallData, RuleRegistryWithCache and GLSurfaceGlx. > > WebGraphicsContext3DInProcessCommandBufferImpl uses the re-named DetachFromThreadHack() - bug 234964 tracks work to remove that use. > > Review URL: https://chromiumcodereview.appspot.com/14299011 BUG=232143, 234964, 243914 TBR=wez@chromium.org Review URL: https://codereview.chromium.org/15819004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202193 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/search_engines/search_provider_install_data.cc | 1 + 1 file changed, 1 insertion(+) (limited to 'chrome/browser/search_engines') diff --git a/chrome/browser/search_engines/search_provider_install_data.cc b/chrome/browser/search_engines/search_provider_install_data.cc index 791a501..af77e8f 100644 --- a/chrome/browser/search_engines/search_provider_install_data.cc +++ b/chrome/browser/search_engines/search_provider_install_data.cc @@ -167,6 +167,7 @@ SearchProviderInstallData::SearchProviderInstallData( // the given notification occurs. new GoogleURLObserver(profile, new GoogleURLChangeNotifier(AsWeakPtr()), ui_death_notification, ui_death_source); + DetachFromThread(); } SearchProviderInstallData::~SearchProviderInstallData() { -- cgit v1.1