From be952c3ca6d93968409b246c9439a7d8c2a06bba Mon Sep 17 00:00:00 2001 From: "estade@chromium.org" Date: Fri, 28 Aug 2009 20:41:10 +0000 Subject: Fix a ton of compiler warnings. Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/shell_dialogs.h | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'chrome/browser/shell_dialogs.h') diff --git a/chrome/browser/shell_dialogs.h b/chrome/browser/shell_dialogs.h index f9a3baa..5098fb4 100644 --- a/chrome/browser/shell_dialogs.h +++ b/chrome/browser/shell_dialogs.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -27,6 +27,9 @@ class BaseShellDialog { // Notifies the dialog box that the listener has been destroyed and it should // no longer be sent notifications. virtual void ListenerDestroyed() = 0; + + protected: + ~BaseShellDialog() {} }; // Shows a dialog box for selecting a file or a folder. @@ -64,6 +67,9 @@ class SelectFileDialog // the user canceling or closing the selection dialog box, for example). // |params| is contextual passed to SelectFile. virtual void FileSelectionCanceled(void* params) {}; + + protected: + ~Listener() {}; }; // Creates a dialog box helper. This object is ref-counted, but the returned @@ -140,6 +146,8 @@ class SelectFontDialog // canceling or closing the selection dialog box, for example). |params| is // contextual passed to SelectFile. virtual void FontSelectionCanceled(void* params) {}; + protected: + ~Listener() {}; }; // Creates a dialog box helper. This object is ref-counted, but the returned -- cgit v1.1