From 2753b39e0c2e83d3b497ebadc2d720f12b74db40 Mon Sep 17 00:00:00 2001 From: "jar@chromium.org" Date: Mon, 28 Dec 2009 06:59:52 +0000 Subject: Cleanup histogram classes mixing SetFlags into FactoryGet arguments Generic cleanup of histogram class, renaming *FactoryGet to FactoryGet, along with reformatting. The macros were cleaned up to use common sub-macros rather than repeating code as much. Removed ThreadSafeHistogram (and associated ASSET_HISTOGRAM macros) since this class was not getting used. I introduced UMA_HISTOGRAM_ENUMERATION to support the common use of LinearHistograms to count various enumerated values. I added a Flags argument to all the FactoryGet routines to help avoid needing to call SetFlags each time a new sample is Add()ed. This also simplifies the code. This will all help prepare for a "don't histogram at all" macro setting so that I can test the impact of the histogram macro calls on performance (since there are now so many active histograms). BUG=31206 r=raman.tenneti Review URL: http://codereview.chromium.org/515033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35295 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/ssl/ssl_blocking_page.cc | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'chrome/browser/ssl/ssl_blocking_page.cc') diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc index d0f3d6a..c443600 100644 --- a/chrome/browser/ssl/ssl_blocking_page.cc +++ b/chrome/browser/ssl/ssl_blocking_page.cc @@ -31,14 +31,11 @@ enum SSLBlockingPageEvent { SHOW, PROCEED, DONT_PROCEED, + UNUSED_ENUM, }; void RecordSSLBlockingPageStats(SSLBlockingPageEvent event) { - static scoped_refptr histogram = - LinearHistogram::LinearHistogramFactoryGet( - "interstial.ssl", 1, 2, 3); - histogram->SetFlags(kUmaTargetedHistogramFlag); - histogram->Add(event); + UMA_HISTOGRAM_ENUMERATION("interstial.ssl", event, UNUSED_ENUM); } } // namespace -- cgit v1.1