From 022eab67d0b3476ee1d35cb463990170c982429b Mon Sep 17 00:00:00 2001 From: "thakis@chromium.org" <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Wed, 13 Jan 2010 04:55:06 +0000 Subject: Mac: UI tweaks for task manager. Nib change: Reduce row height, make scrollbars smaller. Make text in task manager table slightly smaller. Show in decimal digit for %cpu. Show memory in KB/MB, not always in K. Change update frequency from 1s to 2s to match Activity Monitor's default. (all mac-only. ui team is fine with this.) Finally, turn taskman on. BUG=13156 TEST=Open task manager, look at it. Should look & feel similar to Activity Monitor. Review URL: http://codereview.chromium.org/536038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36096 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/task_manager.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'chrome/browser/task_manager.h') diff --git a/chrome/browser/task_manager.h b/chrome/browser/task_manager.h index f49e1e5..1ff02d1 100644 --- a/chrome/browser/task_manager.h +++ b/chrome/browser/task_manager.h @@ -299,7 +299,7 @@ class TaskManagerModel : public URLRequestJobTracker::JobObserver, typedef std::vector<TaskManager::ResourceProvider*> ResourceProviderList; typedef std::map<base::ProcessHandle, ResourceList*> GroupMap; typedef std::map<base::ProcessHandle, base::ProcessMetrics*> MetricsMap; - typedef std::map<base::ProcessHandle, int> CPUUsageMap; + typedef std::map<base::ProcessHandle, double> CPUUsageMap; typedef std::map<TaskManager::Resource*, int64> ResourceValueMap; // Updates the values for all rows. @@ -326,17 +326,17 @@ class TaskManagerModel : public URLRequestJobTracker::JobObserver, // Returns the CPU usage (in %) that should be displayed for the passed // |resource|. - int GetCPUUsage(TaskManager::Resource* resource) const; + double GetCPUUsage(TaskManager::Resource* resource) const; - // Gets the private memory (in KB) that should be displayed for the passed + // Gets the private memory (in bytes) that should be displayed for the passed // resource index. bool GetPrivateMemory(int index, size_t* result) const; - // Gets the shared memory (in KB) that should be displayed for the passed + // Gets the shared memory (in bytes) that should be displayed for the passed // resource index. bool GetSharedMemory(int index, size_t* result) const; - // Gets the physical memory (in KB) that should be displayed for the passed + // Gets the physical memory (in bytes) that should be displayed for the passed // resource index. bool GetPhysicalMemory(int index, size_t* result) const; -- cgit v1.1