From 7f8fdc7ac98c1543f837018c3ff034a0d4fbb26e Mon Sep 17 00:00:00 2001 From: "mad@chromium.org" Date: Tue, 24 Jan 2012 20:07:46 +0000 Subject: There are some application locale which can't be used as a target language for translation... And this is the cause of some crashes... BUG=47807 TEST=Make sure that none of the application languages for which we don't support translating to don't enable the translate context menu option. Review URL: http://codereview.chromium.org/9212035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118880 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/translate/translate_manager_browsertest.cc | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'chrome/browser/translate') diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc index 1057705..8306655 100644 --- a/chrome/browser/translate/translate_manager_browsertest.cc +++ b/chrome/browser/translate/translate_manager_browsertest.cc @@ -956,8 +956,8 @@ TEST_F(TranslateManagerTest, ServerReportsUnsupportedLanguage) { EXPECT_TRUE(GetTranslateInfoBar() == NULL); } -// Tests that no translate infobar is shown when Chrome is in a language that -// the translate server does not support. +// Tests that no translate infobar is shown and context menu is disabled, when +// Chrome is in a language that the translate server does not support. TEST_F(TranslateManagerTest, UnsupportedUILanguage) { std::string original_lang = g_browser_process->GetApplicationLocale(); g_browser_process->SetApplicationLocale("qbz"); @@ -975,6 +975,13 @@ TEST_F(TranslateManagerTest, UnsupportedUILanguage) { // No info-bar should be shown. EXPECT_TRUE(GetTranslateInfoBar() == NULL); + // And the context menu option should be disabled too. + scoped_ptr menu( + TestRenderViewContextMenu::CreateContextMenu(contents())); + menu->Init(); + EXPECT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_TRANSLATE)); + EXPECT_FALSE(menu->IsCommandIdEnabled(IDC_CONTENT_CONTEXT_TRANSLATE)); + g_browser_process->SetApplicationLocale(original_lang); } -- cgit v1.1