From bc118e52c97b739a72a0987a368075429e923ba6 Mon Sep 17 00:00:00 2001 From: "scheib@chromium.org" Date: Wed, 21 May 2014 18:25:34 +0000 Subject: Revert of Unload all apps / extensions when deleting a profile. (https://codereview.chromium.org/266343002/) Reason for revert: Caused crash in official builds when deleting profiles while the chrome:chrome-signin tab is open BUG=374683 TBR=kalman, sky Original issue's description: > Unload all apps / extensions immediately when deleting a profile. > > Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile. > > Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed. > > [49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353 > [49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355 > [49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362 > > BUG=368684 > TEST=Manual testing as described on http://crbug.com/368684#c1 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270890 Review URL: https://codereview.chromium.org/289283013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271926 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/ui/browser.cc | 5 ----- 1 file changed, 5 deletions(-) (limited to 'chrome/browser/ui/browser.cc') diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc index f3e71c1..0643a18 100644 --- a/chrome/browser/ui/browser.cc +++ b/chrome/browser/ui/browser.cc @@ -445,11 +445,6 @@ Browser::Browser(const CreateParams& params) } Browser::~Browser() { - // Stop observing notifications before continuing with destruction. Profile - // destruction will unload extensions and reentrant calls to Browser:: should - // be avoided while it is being torn down. - registrar_.RemoveAll(); - // The tab strip should not have any tabs at this point. DCHECK(tab_strip_model_->empty()); tab_strip_model_->RemoveObserver(this); -- cgit v1.1