From caee07992a65f592686c309b011a4b6b8a8ce891 Mon Sep 17 00:00:00 2001 From: "ben@chromium.org" Date: Fri, 19 Nov 2010 21:19:36 +0000 Subject: Fix a couple of locations that should have been passing show_window = true in NavigateParams. BUG=none TEST= Bug 1: open an incognito window. switch back to the non-incognito window then right click a link and choose "open in incognito window." link should be opened in new tab in existing incognito window and that window activated. bug is that this happens but window is not activated. Bug 2: open an app frame (e.g. chrome --app=http://mail.google.com/). click on a link that would open a new tab (which can't be opened in an app frame). If an existing chrome window would be the target that window is never activated. Review URL: http://codereview.chromium.org/5219005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66818 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/ui/browser.cc | 2 ++ 1 file changed, 2 insertions(+) (limited to 'chrome/browser/ui/browser.cc') diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc index 847f011..1415035 100644 --- a/chrome/browser/ui/browser.cc +++ b/chrome/browser/ui/browser.cc @@ -2731,6 +2731,7 @@ void Browser::OpenURLFromTab(TabContents* source, params.referrer = referrer; params.disposition = disposition; params.tabstrip_add_types = TabStripModel::ADD_NONE; + params.show_window = true; browser::Navigate(¶ms); } @@ -2781,6 +2782,7 @@ void Browser::AddNewContents(TabContents* source, tabstrip_model()->GetWrapperIndex(source)); params.disposition = disposition; params.window_bounds = initial_pos; + params.show_window = true; browser::Navigate(¶ms); } -- cgit v1.1