From 99030190fefdd1ee983b3b14c746bba79cfcb5d1 Mon Sep 17 00:00:00 2001 From: "machenbach@chromium.org" Date: Tue, 29 Apr 2014 13:11:30 +0000 Subject: Revert of Password bubble: Introduce a command to open the bubble. (https://codereview.chromium.org/246393004/) Reason for revert: This is causing leaks on linux asan lsan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/2361 Original issue's description: > Password bubble: ManagePasswordsIconView is now a BubbleIconView. > > This CL introduces a new browser command to open the Manage Passwords bubble, > and converts the ManagePasswordsIconView class into a subclass of > BubbleIconView, which uses the new command to control the bubble's state. > This allows us to more easily test the view and the UI controller, as each > object's job is now more clearly defined (and the view is now doing a good > deal less work), and to independently verify that the command is doing the > right thing. > > After this CL, we'll (finally!) have something approaching reasonable test > coverage for the core of the views code. > > BUG=365678 > TBR=cpu@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266859 TBR=markusheintz@chromium.org,vabr@chromium.org,cpu@chromium.org,pkasting@chromium.org,mkwst@chromium.org NOTREECHECKS=true NOTRY=true BUG=365678 Review URL: https://codereview.chromium.org/256333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266862 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/ui/passwords/manage_passwords_icon.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'chrome/browser/ui/passwords/manage_passwords_icon.h') diff --git a/chrome/browser/ui/passwords/manage_passwords_icon.h b/chrome/browser/ui/passwords/manage_passwords_icon.h index 004c8cd..0a44406 100644 --- a/chrome/browser/ui/passwords/manage_passwords_icon.h +++ b/chrome/browser/ui/passwords/manage_passwords_icon.h @@ -42,9 +42,8 @@ class ManagePasswordsIcon { ManagePasswordsIcon(); ~ManagePasswordsIcon(); - // Called from SetState() iff the icon's state has changed in order to do - // whatever platform-specific UI work is necessary given the new state. - virtual void UpdateVisibleUI() = 0; + // Called from SetState() iff the icon's state has changed. + virtual void SetStateInternal(State state) = 0; private: State state_; -- cgit v1.1