From 1bff66d12e811993940e7dd01074768c30e0cd5b Mon Sep 17 00:00:00 2001 From: vabr Date: Tue, 24 Nov 2015 02:21:16 -0800 Subject: Remove ManagePasswordsUIController::NavigateToSmartLockPage Replace it with the equivalent ManagePasswordsUIController::NavigateToExternalPasswordManager. Note: This CL does not remove IDS_PASSWORD_MANAGER_SMART_LOCK_PAGE yet, because it is also used in other pieces of the password manager UI. We need to double-check if it is OK to merge that with chrome::kPasswordManagerAccountDashboardURL, or whether it just should be made a separate constant. Using localisation to get the hl= URL parameter is very likely an overkill, see #0 in http://crbug.com/548259. R=vasilii@chromium.org BUG=548259 Review URL: https://codereview.chromium.org/1467993002 Cr-Commit-Position: refs/heads/master@{#361304} --- chrome/browser/ui/passwords/passwords_model_delegate.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'chrome/browser/ui/passwords/passwords_model_delegate.h') diff --git a/chrome/browser/ui/passwords/passwords_model_delegate.h b/chrome/browser/ui/passwords/passwords_model_delegate.h index c104c19..5226225 100644 --- a/chrome/browser/ui/passwords/passwords_model_delegate.h +++ b/chrome/browser/ui/passwords/passwords_model_delegate.h @@ -80,10 +80,8 @@ class PasswordsModelDelegate { const autofill::PasswordForm& form, password_manager::CredentialType credential_type) = 0; - // Two different ways to open a new tab pointing to passwords.google.com. - // TODO(crbug.com/548259) eliminate one of them. + // Open a new tab pointing to passwords.google.com. virtual void NavigateToExternalPasswordManager() = 0; - virtual void NavigateToSmartLockPage() = 0; // Open a new tab, pointing to the Smart Lock help article. virtual void NavigateToSmartLockHelpPage() = 0; // Open a new tab, pointing to the password manager settings page. -- cgit v1.1