From 3de6fd34b8081868e0476341987c8953fd1cfba4 Mon Sep 17 00:00:00 2001 From: "sky@google.com" Date: Fri, 5 Sep 2008 02:44:51 +0000 Subject: Attempt at fixing crash. I believe this is happening during session end, which has a different shutdown path and is possible for the model to be deleted before the view. I'm also adding checking to XPFrame/VistaFrame to make sure the BookmarkBarView doesn't have a parent in the destructor. This shouldn't be possible, but I'm adding the check to be sure;) BUG=1359852 TEST=make sure you don't see problems with bookmarks Review URL: http://codereview.chromium.org/440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1754 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/views/bookmark_bar_view.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'chrome/browser/views/bookmark_bar_view.h') diff --git a/chrome/browser/views/bookmark_bar_view.h b/chrome/browser/views/bookmark_bar_view.h index 507da5d..d48780c 100644 --- a/chrome/browser/views/bookmark_bar_view.h +++ b/chrome/browser/views/bookmark_bar_view.h @@ -216,6 +216,9 @@ class BookmarkBarView : public ChromeViews::View, // for each of the children of the root node from the model. virtual void Loaded(BookmarkBarModel* model); + // Invoked when the model is being deleted. + virtual void BookmarkModelBeingDeleted(BookmarkBarModel* model); + // Invokes added followed by removed. virtual void BookmarkNodeMoved(BookmarkBarModel* model, BookmarkBarNode* old_parent, -- cgit v1.1