From e00e18af2f61e8eec071778f66ef15e8bf671d42 Mon Sep 17 00:00:00 2001 From: "jcampan@chromium.org" Date: Mon, 15 Mar 2010 21:03:13 +0000 Subject: Making browser bubble notifies to its delegate whether it lost focus to a child window. This is used to prevent closing browser/page action bubble when they lose focus to a select popup or alert box. BUG=37784 TEST=Start Chrome with extensions that have a page action and browser action that contains selects (combobox) and a way to show an alert box. Verify that showing the select popup or the alert dialog does not cause the bubble to close. Review URL: http://codereview.chromium.org/899002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41630 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/views/browser_bubble.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'chrome/browser/views/browser_bubble.h') diff --git a/chrome/browser/views/browser_bubble.h b/chrome/browser/views/browser_bubble.h index a75211c..c891785 100644 --- a/chrome/browser/views/browser_bubble.h +++ b/chrome/browser/views/browser_bubble.h @@ -31,10 +31,9 @@ class BrowserBubble { virtual void BubbleGotFocus(BrowserBubble* bubble) {} // Called when the bubble became inactive / lost focus. - // |focused_view| is the NativeView getting the focus, it may be NULL if the - // popup was closed programatically. + // |lost_focus_to_child| is true when a child window became active. virtual void BubbleLostFocus(BrowserBubble* bubble, - gfx::NativeView focused_view) {} + bool lost_focus_to_child) {} }; // Note that the bubble will size itself to the preferred size of |view|. -- cgit v1.1