From 2a3e3c054891c865540524beb4af96ec68c481ba Mon Sep 17 00:00:00 2001 From: "nick@chromium.org" Date: Tue, 6 Oct 2009 18:14:28 +0000 Subject: DOMView: avoid double-detaching. I'm seeing ~DOMView happen after NativeViewHost::Detach has already been done as part of WM_DESTROY. BUG=20339 TEST=cancel the sync login dialog and create app shortcuts dialogs. Review URL: http://codereview.chromium.org/258028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28129 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/views/dom_view.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'chrome/browser/views/dom_view.cc') diff --git a/chrome/browser/views/dom_view.cc b/chrome/browser/views/dom_view.cc index a1bf0dc..cd3dc8f 100644 --- a/chrome/browser/views/dom_view.cc +++ b/chrome/browser/views/dom_view.cc @@ -12,7 +12,7 @@ DOMView::DOMView() : initialized_(false), tab_contents_(NULL) { } DOMView::~DOMView() { - if (tab_contents_.get()) + if (native_view()) Detach(); } -- cgit v1.1