From 7b9627d188d04b224f972fae709e7cb4f61ae504 Mon Sep 17 00:00:00 2001 From: "willchan@chromium.org" Date: Wed, 6 May 2009 18:45:56 +0000 Subject: Render a "sad tab" on tab crash. Uses the NotificationRegistrar to notice TAB_CONTENTS_[DIS]CONNECTED events. When it disconnects, add a SadTabGtk to the TabContentsView. Delete it when the tab contents reconnects. BUG=http://www.crbug.com/11081 TEST=Open http://about:crash. Verify that the sad tab renders properly. Navigate to another page to make sure the SadTabGtk is correctly replaced with a new RenderWidgetHostViewGtk. Review URL: http://codereview.chromium.org/111003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15435 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/views/sad_tab_view.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'chrome/browser/views') diff --git a/chrome/browser/views/sad_tab_view.h b/chrome/browser/views/sad_tab_view.h index 5e9415d..8605c1d 100644 --- a/chrome/browser/views/sad_tab_view.h +++ b/chrome/browser/views/sad_tab_view.h @@ -2,10 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_VIEWS_SAD_TAB_H_ -#define CHROME_BROWSER_VIEWS_SAD_TAB_H_ +#ifndef CHROME_BROWSER_VIEWS_SAD_TAB_VIEW_H_ +#define CHROME_BROWSER_VIEWS_SAD_TAB_VIEW_H_ #include "app/gfx/chrome_font.h" +#include "base/basictypes.h" #include "chrome/views/view.h" class SkBitmap; @@ -51,7 +52,7 @@ class SadTabView : public views::View { gfx::Rect title_bounds_; gfx::Rect message_bounds_; - DISALLOW_EVIL_CONSTRUCTORS(SadTabView); + DISALLOW_COPY_AND_ASSIGN(SadTabView); }; -#endif // CHROME_BROWSER_VIEWS_SAD_TAB_H__ +#endif // CHROME_BROWSER_VIEWS_SAD_TAB_VIEW_H__ -- cgit v1.1