From cd4f1227d897deba8372622343c1bf52a5bd6f0f Mon Sep 17 00:00:00 2001 From: "pfeldman@chromium.org" Date: Tue, 7 Jul 2009 14:25:29 +0000 Subject: DevTools: store devtools split offset only when devtools is being hidden. Otherwise any browser window closed afterwards will overwrite settings with the original ones. Review URL: http://codereview.chromium.org/155140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20026 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/views/frame/browser_view.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'chrome/browser/views') diff --git a/chrome/browser/views/frame/browser_view.cc b/chrome/browser/views/frame/browser_view.cc index fcc2318..a0e0bf1 100644 --- a/chrome/browser/views/frame/browser_view.cc +++ b/chrome/browser/views/frame/browser_view.cc @@ -602,9 +602,6 @@ void BrowserView::Close() { for (; bubble != browser_bubbles_.end(); ++bubble) { (*bubble)->BrowserWindowClosed(); } - - g_browser_process->local_state()->SetInteger( - prefs::kDevToolsSplitLocation, contents_split_->divider_offset()); } void BrowserView::Activate() { @@ -1436,6 +1433,7 @@ void BrowserView::Init() { contents_container_ = new TabContentsContainer; devtools_container_ = new TabContentsContainer; + devtools_container_->SetVisible(false); contents_split_ = new views::SingleSplitView( contents_container_, devtools_container_, @@ -1607,6 +1605,11 @@ void BrowserView::UpdateDevToolsForContents(TabContents* tab_contents) { TabContents* devtools_contents = DevToolsWindow::GetDevToolsContents(tab_contents); devtools_container_->ChangeTabContents(devtools_contents); + if (!devtools_contents && devtools_container_->IsVisible()) { + // Store split offset when hiding devtools window only. + g_browser_process->local_state()->SetInteger( + prefs::kDevToolsSplitLocation, contents_split_->divider_offset()); + } devtools_container_->SetVisible(devtools_contents != NULL); contents_split_->Layout(); } -- cgit v1.1