From e37397a176eac68e8b18b2708e4ee41e131af0bf Mon Sep 17 00:00:00 2001 From: "sky@chromium.org" Date: Tue, 7 Sep 2010 23:02:35 +0000 Subject: Changes the max width for bookmark menus back to 400 and leaves them at 800 for the wrench menu. Apparently folks don't like wide bookmark menus. BUG=50653 TEST=see bug Review URL: http://codereview.chromium.org/3317011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58771 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/views/bookmark_menu_controller_views.cc | 8 ++++++++ chrome/browser/views/bookmark_menu_controller_views.h | 1 + 2 files changed, 9 insertions(+) (limited to 'chrome/browser/views') diff --git a/chrome/browser/views/bookmark_menu_controller_views.cc b/chrome/browser/views/bookmark_menu_controller_views.cc index dfc500d..c86432e 100644 --- a/chrome/browser/views/bookmark_menu_controller_views.cc +++ b/chrome/browser/views/bookmark_menu_controller_views.cc @@ -24,6 +24,10 @@ using views::MenuItemView; +// Max width of a menu. There does not appear to be an OS value for this, yet +// both IE and FF restrict the max width of a menu. +static const int kMaxMenuWidth = 400; + BookmarkMenuController::BookmarkMenuController(Browser* browser, Profile* profile, PageNavigator* navigator, @@ -258,6 +262,10 @@ views::MenuItemView* BookmarkMenuController::GetSiblingMenu( return alt_menu; } +int BookmarkMenuController::GetMaxWidthForMenu() { + return kMaxMenuWidth; +} + void BookmarkMenuController::BookmarkModelChanged() { menu_->Cancel(); } diff --git a/chrome/browser/views/bookmark_menu_controller_views.h b/chrome/browser/views/bookmark_menu_controller_views.h index 639610f..f71196b 100644 --- a/chrome/browser/views/bookmark_menu_controller_views.h +++ b/chrome/browser/views/bookmark_menu_controller_views.h @@ -110,6 +110,7 @@ class BookmarkMenuController : public BaseBookmarkModelObserver, views::MenuItemView::AnchorPosition* anchor, bool* has_mnemonics, views::MenuButton** button); + virtual int GetMaxWidthForMenu(); // BookmarkModelObserver methods. virtual void BookmarkModelChanged(); -- cgit v1.1