From 42d5e16cdfdab7f954ec8512ae66ab8a416ad25a Mon Sep 17 00:00:00 2001 From: "rogerta@chromium.org" Date: Thu, 15 Oct 2009 21:29:31 +0000 Subject: Fix another memory leak in my unit test. TEST=none BUG=24769 Review URL: http://codereview.chromium.org/271109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29191 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/renderer_host/test/site_instance_unittest.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'chrome/browser') diff --git a/chrome/browser/renderer_host/test/site_instance_unittest.cc b/chrome/browser/renderer_host/test/site_instance_unittest.cc index 5791ee0..6ee1a59 100644 --- a/chrome/browser/renderer_host/test/site_instance_unittest.cc +++ b/chrome/browser/renderer_host/test/site_instance_unittest.cc @@ -468,12 +468,16 @@ TEST_F(SiteInstanceTest, GetSiteInstanceMap) { scoped_ptr p2(new TestingProfile()); scoped_ptr p3(new DerivedTestingProfile(p1.get())); + // In this test, instances 1 and 2 will be deleted automatically when the + // SiteInstance objects they return are deleted. However, instance 3 never + // returns any SitesIntance objects in this test, so will not be automatically + // deleted. It must be deleted manually. TestBrowsingInstance* instance1(new TestBrowsingInstance(p1.get(), &deleteCounter)); TestBrowsingInstance* instance2(new TestBrowsingInstance(p2.get(), &deleteCounter)); - TestBrowsingInstance* instance3(new TestBrowsingInstance(p3.get(), - &deleteCounter)); + scoped_refptr instance3( + new TestBrowsingInstance(p3.get(), &deleteCounter)); instance1->use_process_per_site = true; instance2->use_process_per_site = true; -- cgit v1.1