From 6314e6f6d7ac203479afe79a46a3e592a2a8da69 Mon Sep 17 00:00:00 2001 From: "phajdan.jr@chromium.org" Date: Wed, 15 Jul 2009 16:07:14 +0000 Subject: Fix a bunch of minor Coverity issues. - pass more things by const reference - check return codes (minor severity) Review URL: http://codereview.chromium.org/149643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20731 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/net/chrome_url_request_context.cc | 6 +++--- chrome/browser/net/chrome_url_request_context.h | 2 +- chrome/browser/net/dns_master_unittest.cc | 1 - chrome/browser/net/referrer.cc | 2 +- chrome/browser/net/referrer.h | 2 +- chrome/browser/net/url_fetcher_protect.cc | 5 +++-- chrome/browser/net/url_fetcher_protect.h | 4 ++-- chrome/browser/net/url_fetcher_unittest.cc | 4 ++-- chrome/browser/net/url_fixer_upper.cc | 5 +++-- 9 files changed, 16 insertions(+), 15 deletions(-) (limited to 'chrome/browser') diff --git a/chrome/browser/net/chrome_url_request_context.cc b/chrome/browser/net/chrome_url_request_context.cc index 0ddd745..3668328 100644 --- a/chrome/browser/net/chrome_url_request_context.cc +++ b/chrome/browser/net/chrome_url_request_context.cc @@ -334,12 +334,12 @@ void ChromeURLRequestContext::Observe(NotificationType type, &ChromeURLRequestContext::OnAcceptLanguageChange, accept_language)); } else if (*pref_name_in == prefs::kCookieBehavior) { - net::CookiePolicy::Type type = net::CookiePolicy::FromInt( + net::CookiePolicy::Type policy_type = net::CookiePolicy::FromInt( prefs_->GetInteger(prefs::kCookieBehavior)); g_browser_process->io_thread()->message_loop()->PostTask(FROM_HERE, NewRunnableMethod(this, &ChromeURLRequestContext::OnCookiePolicyChange, - type)); + policy_type)); } } else if (NotificationType::EXTENSIONS_LOADED == type) { ExtensionPaths* new_paths = new ExtensionPaths; @@ -418,7 +418,7 @@ bool ChromeURLRequestContext::allowSendingCookies(const URLRequest* request) } void ChromeURLRequestContext::OnAcceptLanguageChange( - std::string accept_language) { + const std::string& accept_language) { DCHECK(MessageLoop::current() == ChromeThread::GetMessageLoop(ChromeThread::IO)); accept_language_ = diff --git a/chrome/browser/net/chrome_url_request_context.h b/chrome/browser/net/chrome_url_request_context.h index c709858..49564b7 100644 --- a/chrome/browser/net/chrome_url_request_context.h +++ b/chrome/browser/net/chrome_url_request_context.h @@ -86,7 +86,7 @@ private: const NotificationDetails& details); // Callback for when the accept language changes. - void OnAcceptLanguageChange(std::string accept_language); + void OnAcceptLanguageChange(const std::string& accept_language); // Callback for when the cookie policy changes. void OnCookiePolicyChange(net::CookiePolicy::Type type); diff --git a/chrome/browser/net/dns_master_unittest.cc b/chrome/browser/net/dns_master_unittest.cc index c2b3d27..61ffd68 100644 --- a/chrome/browser/net/dns_master_unittest.cc +++ b/chrome/browser/net/dns_master_unittest.cc @@ -582,7 +582,6 @@ TEST_F(DnsMasterTest, PriorityQueuePushPopTest) { EXPECT_TRUE(queue.IsEmpty()); // Then check low priority queue FIFO functionality. - queue.IsEmpty(); queue.Push("a", DnsHostInfo::PAGE_SCAN_MOTIVATED); EXPECT_FALSE(queue.IsEmpty()); queue.Push("b", DnsHostInfo::OMNIBOX_MOTIVATED); diff --git a/chrome/browser/net/referrer.cc b/chrome/browser/net/referrer.cc index 283faf6..bf171e5 100644 --- a/chrome/browser/net/referrer.cc +++ b/chrome/browser/net/referrer.cc @@ -65,7 +65,7 @@ void Referrer::DeleteLeastUseful() { } void Referrer::AccrueValue(const base::TimeDelta& delta, - const std::string host) { + const std::string& host) { HostNameMap::iterator it = find(host); // Be careful that we weren't evicted from this referrer in DeleteLeastUseful. if (it != end()) diff --git a/chrome/browser/net/referrer.h b/chrome/browser/net/referrer.h index 69c0278..8c252b6 100644 --- a/chrome/browser/net/referrer.h +++ b/chrome/browser/net/referrer.h @@ -69,7 +69,7 @@ class Referrer : public HostNameMap { // Record additional usefulness of having this host name in the list. // Value is expressed as positive latency of amount delta. - void AccrueValue(const base::TimeDelta& delta, const std::string host); + void AccrueValue(const base::TimeDelta& delta, const std::string& host); // Trim the Referrer, by first diminishing (scaling down) the latency for each // ReferredValue. diff --git a/chrome/browser/net/url_fetcher_protect.cc b/chrome/browser/net/url_fetcher_protect.cc index 8798b5a..748a675 100644 --- a/chrome/browser/net/url_fetcher_protect.cc +++ b/chrome/browser/net/url_fetcher_protect.cc @@ -144,7 +144,8 @@ URLFetcherProtectManager* URLFetcherProtectManager::GetInstance() { return protect_manager_.get(); } -URLFetcherProtectEntry* URLFetcherProtectManager::Register(std::string id) { +URLFetcherProtectEntry* URLFetcherProtectManager::Register( + const std::string& id) { AutoLock lock(lock_); ProtectService::iterator i = services_.find(id); @@ -161,7 +162,7 @@ URLFetcherProtectEntry* URLFetcherProtectManager::Register(std::string id) { } URLFetcherProtectEntry* URLFetcherProtectManager::Register( - std::string id, URLFetcherProtectEntry* entry) { + const std::string& id, URLFetcherProtectEntry* entry) { AutoLock lock(lock_); ProtectService::iterator i = services_.find(id); diff --git a/chrome/browser/net/url_fetcher_protect.h b/chrome/browser/net/url_fetcher_protect.h index 9b121b7..5e069fa 100644 --- a/chrome/browser/net/url_fetcher_protect.h +++ b/chrome/browser/net/url_fetcher_protect.h @@ -124,9 +124,9 @@ class URLFetcherProtectManager { // Registers a new entry in this service. If the entry already exists, // just returns it. - URLFetcherProtectEntry* Register(std::string id); + URLFetcherProtectEntry* Register(const std::string& id); // Always registers the entry even when it exists. - URLFetcherProtectEntry* Register(std::string id, + URLFetcherProtectEntry* Register(const std::string& id, URLFetcherProtectEntry* entry); private: diff --git a/chrome/browser/net/url_fetcher_unittest.cc b/chrome/browser/net/url_fetcher_unittest.cc index 4216eb0..91deec0 100644 --- a/chrome/browser/net/url_fetcher_unittest.cc +++ b/chrome/browser/net/url_fetcher_unittest.cc @@ -357,7 +357,7 @@ TEST_F(URLFetcherTest, DifferentThreadsTest) { // message loop will be shut down automatically as the thread goes out of // scope. base::Thread t("URLFetcher test thread"); - t.Start(); + ASSERT_TRUE(t.Start()); t.message_loop()->PostTask(FROM_HERE, new FetcherWrapperTask(this, GURL(server->TestServerPage("defaultresponse")))); @@ -456,7 +456,7 @@ TEST_F(URLFetcherCancelTest, ReleasesContext) { // message loop will be shut down automatically as the thread goes out of // scope. base::Thread t("URLFetcher test thread"); - t.Start(); + ASSERT_TRUE(t.Start()); t.message_loop()->PostTask(FROM_HERE, new FetcherWrapperTask(this, url)); MessageLoop::current()->Run(); diff --git a/chrome/browser/net/url_fixer_upper.cc b/chrome/browser/net/url_fixer_upper.cc index 4097b88..fa572c3 100644 --- a/chrome/browser/net/url_fixer_upper.cc +++ b/chrome/browser/net/url_fixer_upper.cc @@ -29,7 +29,7 @@ namespace { // UTF8 to UTF16. Instead of this after-the-fact adjustment, we should parse it // in the correct string format to begin with. url_parse::Component UTF8ComponentToWideComponent( - string text_utf8, + const string& text_utf8, const url_parse::Component& component_utf8) { if (component_utf8.len == -1) return url_parse::Component(); @@ -44,7 +44,8 @@ url_parse::Component UTF8ComponentToWideComponent( return component_w; } -void UTF8PartsToWideParts(string text_utf8, const url_parse::Parsed& parts_utf8, +void UTF8PartsToWideParts(const string& text_utf8, + const url_parse::Parsed& parts_utf8, url_parse::Parsed* parts) { if (IsStringASCII(text_utf8)) { *parts = parts_utf8; -- cgit v1.1