From b15a406c41e2ef0c053256edc76696c84d9bfe99 Mon Sep 17 00:00:00 2001 From: "jeremy@chromium.org" Date: Tue, 6 Dec 2011 16:40:40 +0000 Subject: Remove code to collect spellchecker stats These stats were originally introduced to gauge the use of Hunspell vs the native spellchecker on OS X. Now that we know that Hunspell is hardly used, the code can be removed. BUG=69944 TEST=None Review URL: http://codereview.chromium.org/8805025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113218 0039d316-1c4b-4281-b951-d872f2087c98 --- .../browser/spellchecker/spellcheck_host_impl.cc | 36 ---------------------- 1 file changed, 36 deletions(-) (limited to 'chrome/browser') diff --git a/chrome/browser/spellchecker/spellcheck_host_impl.cc b/chrome/browser/spellchecker/spellcheck_host_impl.cc index 7d4ac5a..a3846d9 100644 --- a/chrome/browser/spellchecker/spellcheck_host_impl.cc +++ b/chrome/browser/spellchecker/spellcheck_host_impl.cc @@ -32,9 +32,6 @@ #include "net/url_request/url_request_context_getter.h" #include "third_party/hunspell/google/bdict.h" #include "ui/base/l10n/l10n_util.h" -#if defined(OS_MACOSX) -#include "base/metrics/histogram.h" -#endif using content::BrowserThread; @@ -48,32 +45,6 @@ FilePath GetFirstChoiceFilePath(const std::string& language) { return SpellCheckCommon::GetVersionedFileName(language, dict_dir); } -#if defined(OS_MACOSX) -// Collect metrics on how often Hunspell is used on OS X vs the native -// spellchecker. -void RecordSpellCheckStats(bool native_spellchecker_used, - const std::string& language) { - CR_DEFINE_STATIC_LOCAL(std::set, languages_seen, ()); - - // Only count a language code once for each session.. - if (languages_seen.find(language) != languages_seen.end()) { - return; - } - languages_seen.insert(language); - - enum { - SPELLCHECK_OSX_NATIVE_SPELLCHECKER_USED = 0, - SPELLCHECK_HUNSPELL_USED = 1 - }; - - bool engine_used = native_spellchecker_used ? - SPELLCHECK_OSX_NATIVE_SPELLCHECKER_USED : - SPELLCHECK_HUNSPELL_USED; - - UMA_HISTOGRAM_COUNTS("SpellCheck.OSXEngineUsed", engine_used); -} -#endif - #if defined(OS_WIN) FilePath GetFallbackFilePath(const FilePath& first_choice) { FilePath dict_dir; @@ -132,9 +103,6 @@ void SpellCheckHostImpl::Initialize() { if (SpellCheckerPlatform::SpellCheckerAvailable() && SpellCheckerPlatform::PlatformSupportsLanguage(language_)) { -#if defined(OS_MACOSX) - RecordSpellCheckStats(true, language_); -#endif use_platform_spellchecker_ = true; SpellCheckerPlatform::SetLanguage(language_); MessageLoop::current()->PostTask(FROM_HERE, @@ -143,10 +111,6 @@ void SpellCheckHostImpl::Initialize() { return; } -#if defined(OS_MACOSX) - RecordSpellCheckStats(false, language_); -#endif - BrowserThread::PostTaskAndReply(BrowserThread::FILE, FROM_HERE, base::Bind(&SpellCheckHostImpl::InitializeDictionaryLocation, base::Unretained(this)), -- cgit v1.1