From 06c2ba3165d8b02364bf818d5028a7cb4fe48ac0 Mon Sep 17 00:00:00 2001 From: brettw Date: Thu, 26 Nov 2015 01:21:25 -0800 Subject: New build flag system, convert Google Now flag This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included. Converts Google Now to use this and remove the global google now define and grit define. Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False"). Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency. Reland of https://codereview.chromium.org/1475513006/ Reland of https://codereview.chromium.org/1458653002/ TBR=mark@chromium.org Review URL: https://codereview.chromium.org/1469383005 Cr-Commit-Position: refs/heads/master@{#361854} --- chrome/chrome.gyp | 1 + 1 file changed, 1 insertion(+) (limited to 'chrome/chrome.gyp') diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index cfd46cc..9495002 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -104,6 +104,7 @@ 'chrome_browser_ui.gypi', 'chrome_common.gypi', 'chrome_installer_util.gypi', + 'chrome_features.gypi', ], 'conditions': [ ['OS!="ios"', { -- cgit v1.1