From 4ebb4f136e3e5040351b4e29ca79fe1153ce606d Mon Sep 17 00:00:00 2001 From: "evan@chromium.org" Date: Thu, 26 Nov 2009 00:15:50 +0000 Subject: Refactor OS-dependent filename exclusion patterns Rather than duplicate logic in the tree, merge all of the shared rules about patterns in filenames into one common set. The pattern is: "if (OS != x): exclude x's files." This is especially needed for upcoming changes that bring in a few more platform-specific (FreeBSD, OpenBSD, Solaris(?)) files. Review URL: http://codereview.chromium.org/443011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33160 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/chrome.gyp | 30 ------------------------------ 1 file changed, 30 deletions(-) (limited to 'chrome/chrome.gyp') diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index b2ab988..e3cc815 100755 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -190,36 +190,6 @@ }], ], # conditions }, # variables - 'target_defaults': { - 'sources/': [ - ['exclude', '/(cocoa|gtk|win)/'], - ['exclude', '_(cocoa|gtk|linux|mac|posix|skia|win|views|x)(_unittest)?(_mac)?\\.(cc|mm?)$'], - ['exclude', '/(gtk|win|x11)_[^/]*\\.cc$'], - ], - 'conditions': [ - ['OS=="linux" or OS=="freebsd"', {'sources/': [ - ['include', '/gtk/'], - ['include', '_(gtk|linux|posix|skia|x)(_unittest)?\\.cc$'], - ['include', '/(gtk|x11)_[^/]*\\.cc$'], - ]}], - ['OS=="mac"', {'sources/': [ - ['include', '/cocoa/'], - ['include', '_(cocoa|mac|posix)(_unittest)?(_mac)?\\.(cc|mm?)$'], - ]}, { # else: OS != "mac" - 'sources/': [ - ['exclude', '\\.mm?$'], - ], - }], - ['OS=="win"', {'sources/': [ - ['include', '_(views|win)(_unittest)?\\.cc$'], - ['include', '/win/'], - ['include', '/(views|win)_[^/]*\\.cc$'], - ]}], - ['OS=="linux" and toolkit_views==1', {'sources/': [ - ['include', '_views\\.cc$'], - ]}], - ], - }, 'targets': [ { # TODO(mark): It would be better if each static library that needed -- cgit v1.1