From 57db18ac0e41bf819e0a916635373b965a5facfb Mon Sep 17 00:00:00 2001 From: "ronghuawu@chromium.org" Date: Wed, 28 May 2014 18:48:29 +0000 Subject: Revert 273199 "Enable mac_strip_release under ASan on OSX. Remov..." Seems causing failures on mac asan bots, e.g: http://build.chromium.org/p/chromium.memory/waterfall?builder=Mac%20ASan%2064%20Tests%20(1) > Enable mac_strip_release under ASan on OSX. Remove the .saves files. > > Unce upon a time the ASan runtime library used to be statically linked into > the executables on OSX. > Because that library provided a number of API functions needed by the shared > libraries, we had custom ASan-specific .saves files that told the `strip` > utility to preserve those functions when stripping the executables. > > Then ASan switched to using dynamic runtime library, which instantly broke the > stripping step, because the executables weren't necessarily referencing all the > ASan API functions (issue 242503). > As a result, stripping has been disabled, and we haven't had .dSYM debug info > for ASan builds for more than a year now (issue 148383). > > Because the ASan API functions are now undefined in the executables, it's > actually senseless to use the .saves files to preserve those functions. > This CL deletes the .saves files and turns mac_strip_release on for ASan > builds. > > BUG=148383,242503,170739,166857 > R=mark@chromium.org > > Review URL: https://codereview.chromium.org/292153006 TBR=glider@chromium.org Review URL: https://codereview.chromium.org/298333007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273302 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/chrome.gyp | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'chrome/chrome.gyp') diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index 2810f96..19609cc 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -241,6 +241,12 @@ 'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)', }, }], + ['asan==1', { + 'xcode_settings': { + # Override the outer definition of CHROMIUM_STRIP_SAVE_FILE. + 'CHROMIUM_STRIP_SAVE_FILE': 'app/app_asan.saves', + }, + }], ['component=="shared_library"', { 'xcode_settings': { 'LD_RUNPATH_SEARCH_PATHS': [ -- cgit v1.1