From 40da3e0c42d83eb6225d9d340780bd6e3af14b6c Mon Sep 17 00:00:00 2001 From: "jcivelli@chromium.org" Date: Wed, 24 Oct 2012 22:03:38 +0000 Subject: Because of UID isolation on Android, crash dump generation has to happen in-process for renderers as well (as the browser cannot access all the necessary states of the renderer process). Breakpad has support for generating minidumps to a passed FD (as the renderer process on Android does not have permission to create file), so the flow on Android is: - when a render process is created the browser creates a file and passes its FD to the process - the renderer process initializes Breakpad with that FD - if there is a crash, Breakpad generates the minidump to that FD. - when the browser process detects a renderer stopped it checks the minidump file. If it's empty it deletes the file. If it's not empty, it means there was a crasher in which case it moves it to the crash dump folder for it to be picked up and uploaded by the Java side. BUG=None TEST=Test that minidumps are generated and uploaded when visiting about:crash and about:crashbrowserforrealz on Android and desktop Chrome. Review URL: https://chromiumcodereview.appspot.com/11189068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163917 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/chrome_browser.gypi | 2 ++ 1 file changed, 2 insertions(+) (limited to 'chrome/chrome_browser.gypi') diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index a090c42..b5ba698 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -120,6 +120,8 @@ 'browser/android/chrome_web_contents_delegate_android.h', 'browser/android/content_view_util.cc', 'browser/android/content_view_util.h', + 'browser/android/crash_dump_manager.cc', + 'browser/android/crash_dump_manager.h', 'browser/android/devtools_server.cc', 'browser/android/devtools_server.h', 'browser/android/intent_helper.cc', -- cgit v1.1