From 00b50b22e8bc53c68e655662d36c10c986e45b9c Mon Sep 17 00:00:00 2001 From: "sail@chromium.org" Date: Wed, 27 Mar 2013 18:06:26 +0000 Subject: Revert 190732 "Revert 190584 "Alternate NTP Mac: Show overlay at..." Confirmed that this didn't cause bug 224002. BUG=224002 > Revert 190584 "Alternate NTP Mac: Show overlay at fixed position" > > Speculative revert to see this fixes the Mac startup perf regression. > > BUG=224002 > > > Alternate NTP Mac: Show overlay at fixed position > > > > Previously the overlay was shown at the bottom of the toolbar. The height of > > the bookmark bar changes if the bookmark bar is attached. This meant that the > > overlay would change positions (relative to the omnibox) depending on the > > bookmark bar's attached state. > > > > With this CL we now show the overlay at the fixed offset from the omnibox. > > > > One side effect of this is that the bottom of the toolbar can no longer act > > as a separator for the overlay. I've changed the overlay to draw its own > > separator. > > > > Screenshot: http://i.imgur.com/ub9gfDo.png > > > > BUG=173475, 174077 > > TBR=sky@chromium.org > > > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190213 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190519 > > > > Review URL: https://chromiumcodereview.appspot.com/12674019 > > TBR=sail@chromium.org > Review URL: https://codereview.chromium.org/13006019 TBR=sail@chromium.org Review URL: https://codereview.chromium.org/12770029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190978 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/chrome_browser_ui.gypi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'chrome/chrome_browser_ui.gypi') diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi index 8ba57f4..3ab08b3 100644 --- a/chrome/chrome_browser_ui.gypi +++ b/chrome/chrome_browser_ui.gypi @@ -753,8 +753,8 @@ 'browser/ui/cocoa/tab_contents/favicon_util_mac.mm', 'browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.h', 'browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.mm', - 'browser/ui/cocoa/tab_contents/overlay_drop_shadow_view.h', - 'browser/ui/cocoa/tab_contents/overlay_drop_shadow_view.mm', + 'browser/ui/cocoa/tab_contents/overlay_separator_view.h', + 'browser/ui/cocoa/tab_contents/overlay_separator_view.mm', 'browser/ui/cocoa/tab_contents/overlayable_contents_controller.h', 'browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm', 'browser/ui/cocoa/tab_contents/render_view_context_menu_mac.h', -- cgit v1.1