From 66761b95332549f825999e482c17c94675275f49 Mon Sep 17 00:00:00 2001 From: "pkasting@chromium.org" Date: Fri, 25 Jun 2010 21:30:38 +0000 Subject: Massively simplify the NetworkChangeNotifier infrastructure: * Use a process-wide object (singleton pattern) * Create/destroy this object on the main thread, make it outlive all consumers * Make observer-related functions threadsafe As a result, the notifier can now be used by any thread (eliminating things like NetworkChangeObserverProxy and NetworkChangeNotifierProxy, and expanding its usefulness); its creation and inner workings are much simplified (eliminating implementation-specific classes); and it is simpler to access (eliminating things like NetworkChangeNotifierThread and a LOT of passing pointers around). BUG=none TEST=Unittests; network changes still trigger notifications Review URL: http://codereview.chromium.org/2802015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50895 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/chrome_common.gypi | 5 ----- 1 file changed, 5 deletions(-) (limited to 'chrome/chrome_common.gypi') diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi index f4a8e6e..444f881 100644 --- a/chrome/chrome_common.gypi +++ b/chrome/chrome_common.gypi @@ -324,11 +324,6 @@ 'common/net/http_return.h', 'common/net/net_resource_provider.cc', 'common/net/net_resource_provider.h', - 'common/net/network_change_notifier_proxy.cc', - 'common/net/network_change_notifier_proxy.h', - 'common/net/network_change_notifier_thread.h', - 'common/net/network_change_observer_proxy.cc', - 'common/net/network_change_observer_proxy.h', 'common/net/socket_stream.h', 'common/net/url_fetcher.cc', 'common/net/url_fetcher.h', -- cgit v1.1