From 543bb913c76e73e6548991f48886e8d60633fbdd Mon Sep 17 00:00:00 2001 From: davidben Date: Mon, 10 Aug 2015 10:18:40 -0700 Subject: Fix startup race in initializing DevToolsNetworkController. DevToolsNetworkController is accessible from the UI half of the Profile, which means that it must be created on the UI thread. It, however, is currently created on the IO, so this doesn't work. Instead, split into the single-threaded controller (no need for a Helper class in unit tests) and a handle which does the cross-thread management. On the UI thread, only DevToolsNetworkControllerHandle may be used. On the IO thread, a Handle may be exchanged for the underlying controller. BUG=515492 Review URL: https://codereview.chromium.org/1279603002 Cr-Commit-Position: refs/heads/master@{#342639} --- chrome/chrome_debugger.gypi | 2 ++ 1 file changed, 2 insertions(+) (limited to 'chrome/chrome_debugger.gypi') diff --git a/chrome/chrome_debugger.gypi b/chrome/chrome_debugger.gypi index 7beba91..48e1ea3 100644 --- a/chrome/chrome_debugger.gypi +++ b/chrome/chrome_debugger.gypi @@ -29,6 +29,8 @@ 'browser/devtools/devtools_network_conditions.h', 'browser/devtools/devtools_network_controller.cc', 'browser/devtools/devtools_network_controller.h', + 'browser/devtools/devtools_network_controller_handle.cc', + 'browser/devtools/devtools_network_controller_handle.h', 'browser/devtools/devtools_network_interceptor.cc', 'browser/devtools/devtools_network_interceptor.h', 'browser/devtools/devtools_network_protocol_handler.cc', -- cgit v1.1