From 062cdbbade5d2c804bce7ff7b320d36cb97c39da Mon Sep 17 00:00:00 2001 From: knn Date: Fri, 26 Jun 2015 11:18:42 -0700 Subject: Introduce a layering in the invalidation component as public and impl. The invalidation component has dependencies due to specific implementations of the inv_client, inv_service etc. Consumers of invalidations do not need to depend on these. This change exports the InvalidationHandler interface in a separate target 'invalidation_public' which only depends on //google/cacheinvalidation Thus the signin component can implement to InvalidationHandler to refresh account information without introducing a cyclic dependency. The crux of the change is: Move {components/invalidation/ => components/invalidation/public}: -ack_handle.cc -ack_handle.h -ack_handler.cc -ack_handler.h -invalidation.cc -invalidation.h -invalidation_export.h -invalidation_handler.cc -invalidation_handler.h -invalidation_service.h -invalidation_util.cc -invalidation_util.h -invalidator_state.cc -invalidator_state.h -object_id_invalidation_map.cc -object_id_invalidation_map.h -single_object_invalidation_set.cc -single_object_invalidation_set.h Move {components/invalidation/ => components/invalidation/impl}: other files Thus the dependency chain is: //chrome/browser/ -> //components/invalidation/impl -> components/invalidation/public Now invalidation consumers can directly depend on //components/invalidation/public which has only //google/cacheinvalidation has a dependency. BUG=503131 Review URL: https://codereview.chromium.org/1191393008 Cr-Commit-Position: refs/heads/master@{#336413} --- chrome/chrome_tests.gypi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'chrome/chrome_tests.gypi') diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index fc6f020..98c85c2 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -2678,7 +2678,7 @@ 'chrome', 'test_support_common', '../base/base.gyp:base', - '../components/components.gyp:invalidation', + '../components/components.gyp:invalidation_impl', '../components/components.gyp:invalidation_test_support', '../net/net.gyp:net', '../skia/skia.gyp:skia', -- cgit v1.1